Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixbug, Content-Type validate #39522

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

worker24h
Copy link

OkHttp,'; charset=utf-8' append to 'application/json' by self, for example

POST /api/v1/push HTTP/1.1
User-Agent: PostmanRuntime/7.29.2
Accept: */*
Accept-Encoding: gzip, deflate, br
Authorization: Basic AAAAAAAAAAAAADDDDDDDDD=
Content-Type: application/json; charset=UTF-8
Content-Length: 213
Host: abc-test-ok.aaa
Connection: keep-alive

but PostMan is not.
So, to be compatible with these two forms (application/json, application/json; charset=utf-8) to strings.Contains

Proposed commit message

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

OkHttp,'; charset=utf-8' append to 'application/json' by self  , but PostMan is not. So, to be compatible with these two forms (application/json, application/json; charset=utf-8) to strings.Contains
@worker24h worker24h requested a review from a team as a code owner May 11, 2024 08:00
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 11, 2024
Copy link

❌ Author of the following commits did not sign a Contributor Agreement:
c765900

Please, read and sign the above mentioned agreement if you want to contribute to this project

@botelastic
Copy link

botelastic bot commented May 11, 2024

This pull request doesn't have a Team:<team> label.

Copy link
Contributor

mergify bot commented May 11, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @worker24h? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant