Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Draft] [AWS] Support pulling region from arbitrary domains for aws-s3 input SQS queue url #39521

Closed
wants to merge 1 commit into from

Conversation

strawgate
Copy link
Contributor

@strawgate strawgate commented May 11, 2024

Proposed commit message

Draft/test fix for https://github.com/elastic/enhancements/issues/21469

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

None

Author's Checklist

  • [ ]

How to test this PR locally

filebeat.inputs:
- type: aws-s3
  queue_url: https://sqs.ap-southeast-1.subdomain.domain.com/1234/test-s3-queue
  access_key_id: 'tomato'
  secret_access_key: 'tomato'
  session_token: 'tomato'

Ensure you do not see a region from queue_url parsing errors

Related issues

Relates https://github.com/elastic/enhancements/issues/21469

@strawgate strawgate requested a review from a team as a code owner May 11, 2024 05:17
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 11, 2024
@botelastic
Copy link

botelastic bot commented May 11, 2024

This pull request doesn't have a Team:<team> label.

Copy link
Contributor

mergify bot commented May 11, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @strawgate? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@strawgate
Copy link
Contributor Author

I dont actually think this PR is needed at the moment but drafted it anyway

@strawgate strawgate closed this May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant