Remove hardcoded module definitions in CI #39506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
needs_team
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
dliappis
force-pushed
the
remove-hardcoded-modules
branch
3 times, most recently
from
3e0ce27
to
8e14111
Compare
dliappis
added
backport-v7.17.0
dliappis
force-pushed
the
remove-hardcoded-modules
branch
4 times, most recently
from
f8a5d80
to
d630e5b
Compare
For reasons described in [^1], we hard coded `aws` or `kubernetes` for the env var `MODULE`, when no file changes were detected under `modules/` per project. This commit reverts this and brings back the default behavior which is not to set the MODULE env var when nothing has changed. [^1]: elastic/ingest-dev#2993
dliappis
force-pushed
the
remove-hardcoded-modules
branch
from
d630e5b
to
800ff80
Compare
dliappis
added
macOS
dliappis
removed
aws
|
/test |
1 similar comment
|
/test |
dliappis
commented
May 12, 2024
| @@ -57,7 +57,7 @@ steps: | |||
| # defines the MODULE env var based on what's changed in a PR | |||
| source .buildkite/scripts/changesets.sh | |||
| defineModuleFromTheChangeSet metricbeat | |||
| echo "~~~ Will run tests with env var MODULE=$$MODULE" | |||
There was a problem hiding this comment.
We remove references to the env var MODULE because if unset, it fails the command due to undefined variable checks (set -e)
alexsapran
reviewed
May 13, 2024
|
alexsapran
approved these changes
May 13, 2024
mergify bot
pushed a commit
that referenced
this pull request
May 13, 2024
For reasons described in [^1], we hard coded `aws` or `kubernetes` for the env var `MODULE`, when no file changes were detected under `modules/` per project. This commit reverts this and allows all module tests to run if no changesets apply. As discussed in [^1], for the tests to run properly (and not go into an infinite loop) if there are no module changes the `MODULE` env var should **not** be set, rather than set to an empty string. This commit is an important fix as it covers a major delta in test coverage between Jenkins and Buildkite. Closes https://github.com/elastic/ingest-dev/issues/2993 [^1]: https://github.com/elastic/ingest-dev/issues/2993#issuecomment-2104741977 (cherry picked from commit c91503b) # Conflicts: # .buildkite/metricbeat/pipeline.yml
mergify bot
pushed a commit
that referenced
this pull request
May 13, 2024
For reasons described in [^1], we hard coded `aws` or `kubernetes` for the env var `MODULE`, when no file changes were detected under `modules/` per project. This commit reverts this and allows all module tests to run if no changesets apply. As discussed in [^1], for the tests to run properly (and not go into an infinite loop) if there are no module changes the `MODULE` env var should **not** be set, rather than set to an empty string. This commit is an important fix as it covers a major delta in test coverage between Jenkins and Buildkite. Closes https://github.com/elastic/ingest-dev/issues/2993 [^1]: https://github.com/elastic/ingest-dev/issues/2993#issuecomment-2104741977 (cherry picked from commit c91503b)
This was referenced May 13, 2024
mergify bot
pushed a commit
that referenced
this pull request
May 13, 2024
For reasons described in [^1], we hard coded `aws` or `kubernetes` for the env var `MODULE`, when no file changes were detected under `modules/` per project. This commit reverts this and allows all module tests to run if no changesets apply. As discussed in [^1], for the tests to run properly (and not go into an infinite loop) if there are no module changes the `MODULE` env var should **not** be set, rather than set to an empty string. This commit is an important fix as it covers a major delta in test coverage between Jenkins and Buildkite. Closes https://github.com/elastic/ingest-dev/issues/2993 [^1]: https://github.com/elastic/ingest-dev/issues/2993#issuecomment-2104741977 (cherry picked from commit c91503b)
dliappis
added a commit
that referenced
this pull request
May 13, 2024
…9527) For reasons described in [^1], we hard coded `aws` or `kubernetes` for the env var `MODULE`, when no file changes were detected under `modules/` per project. This commit reverts this and allows all module tests to run if no changesets apply. As discussed in [^1], for the tests to run properly (and not go into an infinite loop) if there are no module changes the `MODULE` env var should **not** be set, rather than set to an empty string. This commit is an important fix as it covers a major delta in test coverage between Jenkins and Buildkite. Closes https://github.com/elastic/ingest-dev/issues/2993 [^1]: https://github.com/elastic/ingest-dev/issues/2993#issuecomment-2104741977 (cherry picked from commit c91503b) --------- Co-authored-by: Dimitrios Liappis <dimitrios.liappis@gmail.com>
dliappis
added a commit
that referenced
this pull request
May 13, 2024
For reasons described in [^1], we hard coded `aws` or `kubernetes` for the env var `MODULE`, when no file changes were detected under `modules/` per project. This commit reverts this and allows all module tests to run if no changesets apply. As discussed in [^1], for the tests to run properly (and not go into an infinite loop) if there are no module changes the `MODULE` env var should **not** be set, rather than set to an empty string. This commit is an important fix as it covers a major delta in test coverage between Jenkins and Buildkite. Closes https://github.com/elastic/ingest-dev/issues/2993 [^1]: https://github.com/elastic/ingest-dev/issues/2993#issuecomment-2104741977 (cherry picked from commit c91503b) Co-authored-by: Dimitrios Liappis <dimitrios.liappis@gmail.com>
dliappis
added a commit
that referenced
this pull request
May 13, 2024
For reasons described in [^1], we hard coded `aws` or `kubernetes` for the env var `MODULE`, when no file changes were detected under `modules/` per project. This commit reverts this and allows all module tests to run if no changesets apply. As discussed in [^1], for the tests to run properly (and not go into an infinite loop) if there are no module changes the `MODULE` env var should **not** be set, rather than set to an empty string. This commit is an important fix as it covers a major delta in test coverage between Jenkins and Buildkite. Closes https://github.com/elastic/ingest-dev/issues/2993 [^1]: https://github.com/elastic/ingest-dev/issues/2993#issuecomment-2104741977 (cherry picked from commit c91503b) Co-authored-by: Dimitrios Liappis <dimitrios.liappis@gmail.com>
v1v
added a commit
to v1v/beats
that referenced
this pull request
May 15, 2024
…-actions * upstream/main: (313 commits) github-action: delete opentelemetry workflow (elastic#39559) updatecli: move to the .github folder and support for signed commits (elastic#39472) Osquerybeat: Add action responses data stream (elastic#39143) [winlogbeat] performance improvment; avoid rendering event message twice (elastic#39544) Fix the AWS SDK dependencies issue causing the "not found, ResolveEndpointV2" error (elastic#39454) x-pack/filebeat/input/cel: add http metrics collection (elastic#39503) build(deps): bump github.com/elastic/elastic-agent-libs from 0.9.4 to 0.9.7 (elastic#39424) Remove unused env vars from pipelines (elastic#39534) [BK] - Remove osx steps from branch execution (elastic#39552) [BK] - Remove certain steps from running for Branches (elastic#39533) Allow dependabot report BK status checks (elastic#39540) Remove hardcoded module definitions in CI (elastic#39506) Explicitly set DOCKER_PULL, RACE_DETECTOR and TEST_COVERAGE for pipelines (elastic#39510) Fixed pipelines formatting (elastic#39513) Update filebeat pipeline to match Jenkins steps (elastic#39261) Add error check to groupToEvents so we don't blindly add error values (elastic#39404) Remove fields not needed for session view in add_session_view processor (elastic#39500) `aws-s3` input: Split S3 poller and SQS reader into explicit input objects (elastic#39353) ci(jenkins): remove post-build notifications (elastic#39483) [DOCS] Add the `read_pipeline` cluster privilege for winlogbeat and the `auto_configure` index privilege to beats documentation (elastic#38534) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
For reasons described in 1, we hard coded
awsorkubernetesfor the env varMODULE, when no file changes were detected undermodules/per project.This commit reverts this and allows all module tests to run if no changesets apply. As discussed in 1, for the tests to run properly (and not go into an infinite loop)
if there are no module changes the
MODULEenv var should not be set, rather than set to an empty string.This commit is an important fix as it covers a major delta in test coverage between Jenkins and Buildkite.
Related issues
Closes https://github.com/elastic/ingest-dev/issues/2993
Screenshots
Logs/Tests
aws/macOS/:Windows): https://buildkite.com/elastic/beats/builds/7405#018f666f-797d-415e-a4fa-2911548a6220only failure is x-pack/filebeat Cloud which is unrelated to this PR: https://github.com/elastic/ingest-dev/issues/3312
Footnotes
https://github.com/elastic/ingest-dev/issues/2993#issuecomment-2104741977 ↩ ↩2