Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document havester_limit for Filestream input and fix typo #39244

Merged
merged 1 commit into from Apr 29, 2024

Conversation

belimawr
Copy link
Contributor

Proposed commit message

This commit documents harvester_limit for the filestream input and replaces close_* by the correct key close.on_state_change.*.

Checklist

  • [ ] My code follows the style guidelines of this project
  • [ ] I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files
  • [ ] I have added tests that prove my fix is effective or that my feature works
  • [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

## Author's Checklist
## How to test this PR locally

Related issues

## Use cases
## Screenshots
## Logs

This commit documents `harvester_limit` for the filestream input and
replaces `close_*` by the correct key `close.on_state_change.*`.
@belimawr belimawr added bug docs Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team labels Apr 26, 2024
@belimawr belimawr self-assigned this Apr 26, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Apr 26, 2024
Copy link
Contributor

mergify bot commented Apr 26, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @belimawr? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@belimawr belimawr requested a review from rdner April 26, 2024 20:57
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2024-04-26T20:56:27.276+0000

  • Duration: 11 min 50 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@cmacknz cmacknz added backport-v7.17.0 Automated backport with mergify backport-v8.13.0 Automated backport with mergify backport-v8.14.0 Automated backport with mergify labels Apr 29, 2024
@belimawr belimawr merged commit 59421bb into elastic:main Apr 29, 2024
21 checks passed
@belimawr belimawr deleted the document-harvester-limit branch April 29, 2024 18:24
mergify bot pushed a commit that referenced this pull request Apr 29, 2024
This commit documents `harvester_limit` for the filestream input and
replaces `close_*` by the correct key `close.on_state_change.*`.

(cherry picked from commit 59421bb)
mergify bot pushed a commit that referenced this pull request Apr 29, 2024
This commit documents `harvester_limit` for the filestream input and
replaces `close_*` by the correct key `close.on_state_change.*`.

(cherry picked from commit 59421bb)
mergify bot pushed a commit that referenced this pull request Apr 29, 2024
This commit documents `harvester_limit` for the filestream input and
replaces `close_*` by the correct key `close.on_state_change.*`.

(cherry picked from commit 59421bb)
pierrehilbert pushed a commit that referenced this pull request Apr 30, 2024
…39274)

This commit documents `harvester_limit` for the filestream input and
replaces `close_*` by the correct key `close.on_state_change.*`.

(cherry picked from commit 59421bb)

Co-authored-by: Tiago Queiroz <tiago.queiroz@elastic.co>
pierrehilbert pushed a commit that referenced this pull request Apr 30, 2024
…39275)

This commit documents `harvester_limit` for the filestream input and
replaces `close_*` by the correct key `close.on_state_change.*`.

(cherry picked from commit 59421bb)

Co-authored-by: Tiago Queiroz <tiago.queiroz@elastic.co>
pierrehilbert pushed a commit that referenced this pull request Apr 30, 2024
…39276)

This commit documents `harvester_limit` for the filestream input and
replaces `close_*` by the correct key `close.on_state_change.*`.

(cherry picked from commit 59421bb)

Co-authored-by: Tiago Queiroz <tiago.queiroz@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v7.17.0 Automated backport with mergify backport-v8.13.0 Automated backport with mergify backport-v8.14.0 Automated backport with mergify bug docs Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Filebeat] harvester_limit is not documented for Filestream input
4 participants