Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update x-pack/heartbeat pipeline to match Jenkins #39239

Merged
merged 4 commits into from May 7, 2024

Conversation

oakrizan
Copy link
Contributor

@oakrizan oakrizan commented Apr 26, 2024

Proposed commit message

In scope of https://github.com/elastic/ingest-dev/issues/3254 - updated x-pack/heartbeat pipeline to match same steps & commands as in Jenkins.
Jenkins vs. Buildkite comparison: https://gist.github.com/oakrizan/ad3b982cd59e42d25d80f664a194998b
BK builds: https://buildkite.com/elastic/beats-xpack-heartbeat/builds?branch=oakrizan%3Axpack-heartbeat-fixes

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Apr 26, 2024
Copy link
Contributor

mergify bot commented Apr 26, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @oakrizan? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 26, 2024

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2024-05-07T07:14:06.664+0000

  • Duration: 12 min 0 sec

Test stats 🧪

Test Results
Failed 0
Passed 2
Skipped 0
Total 2

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@oakrizan oakrizan force-pushed the xpack-heartbeat-fixes branch 2 times, most recently from 197b7f3 to 5a10a29 Compare April 26, 2024 16:02
@oakrizan oakrizan force-pushed the xpack-heartbeat-fixes branch 3 times, most recently from 21864d2 to 2d46413 Compare April 26, 2024 16:33
@oakrizan oakrizan added backport-v7.17.0 Automated backport with mergify backport-v8.13.0 Automated backport with mergify Team:Ingest-EngProd backport-v8.14.0 Automated backport with mergify labels Apr 26, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Apr 26, 2024
@oakrizan oakrizan marked this pull request as ready for review April 26, 2024 16:36
@oakrizan oakrizan requested a review from a team as a code owner April 26, 2024 16:36
@oakrizan oakrizan force-pushed the xpack-heartbeat-fixes branch 4 times, most recently from 19a9907 to e17b3a0 Compare April 30, 2024 12:08
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left an optional nit.

.buildkite/x-pack/pipeline.xpack.heartbeat.yml Outdated Show resolved Hide resolved
.buildkite/x-pack/pipeline.xpack.heartbeat.yml Outdated Show resolved Hide resolved
Copy link
Contributor

mergify bot commented May 1, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b xpack-heartbeat-fixes upstream/xpack-heartbeat-fixes
git merge upstream/main
git push upstream xpack-heartbeat-fixes

@oakrizan oakrizan merged commit 4f5b23a into elastic:main May 7, 2024
16 checks passed
mergify bot pushed a commit that referenced this pull request May 7, 2024
* updated win-2016 test cmd

* updated macos namimg

* pr fixes

* removed pipeline masking where irrelevant

(cherry picked from commit 4f5b23a)

# Conflicts:
#	.buildkite/x-pack/pipeline.xpack.heartbeat.yml
mergify bot pushed a commit that referenced this pull request May 7, 2024
* updated win-2016 test cmd

* updated macos namimg

* pr fixes

* removed pipeline masking where irrelevant

(cherry picked from commit 4f5b23a)
mergify bot pushed a commit that referenced this pull request May 7, 2024
* updated win-2016 test cmd

* updated macos namimg

* pr fixes

* removed pipeline masking where irrelevant

(cherry picked from commit 4f5b23a)
oakrizan added a commit that referenced this pull request May 7, 2024
* updated win-2016 test cmd

* updated macos namimg

* pr fixes

* removed pipeline masking where irrelevant

(cherry picked from commit 4f5b23a)

# Conflicts:
#	.buildkite/x-pack/pipeline.xpack.heartbeat.yml
oakrizan added a commit that referenced this pull request May 7, 2024
* updated win-2016 test cmd

* updated macos namimg

* pr fixes

* removed pipeline masking where irrelevant

(cherry picked from commit 4f5b23a)

# Conflicts:
#	.buildkite/x-pack/pipeline.xpack.heartbeat.yml
oakrizan added a commit that referenced this pull request May 7, 2024
* updated win-2016 test cmd

* updated macos namimg

* pr fixes

* removed pipeline masking where irrelevant

(cherry picked from commit 4f5b23a)

Co-authored-by: Olga Naydyonock <olga.naidjonoka@elastic.co>
oakrizan added a commit that referenced this pull request May 7, 2024
* updated win-2016 test cmd

* updated macos namimg

* pr fixes

* removed pipeline masking where irrelevant

(cherry picked from commit 4f5b23a)

Co-authored-by: Olga Naydyonock <olga.naidjonoka@elastic.co>
oakrizan added a commit that referenced this pull request May 7, 2024
…kins (#39421)

* Update x-pack/heartbeat pipeline to match Jenkins (#39239)

* updated win-2016 test cmd

* updated macos namimg

* pr fixes

* removed pipeline masking where irrelevant

(cherry picked from commit 4f5b23a)

# Conflicts:
#	.buildkite/x-pack/pipeline.xpack.heartbeat.yml

* fixed conflicts

---------

Co-authored-by: Olga Naydyonock <olga.naidjonoka@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v7.17.0 Automated backport with mergify backport-v8.13.0 Automated backport with mergify backport-v8.14.0 Automated backport with mergify Team:Ingest-EngProd :Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants