Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MODULE definition for x-pack/dockerlogbeat Go Integration tests #39235

Merged
merged 6 commits into from May 8, 2024

Conversation

oakrizan
Copy link
Contributor

@oakrizan oakrizan commented Apr 26, 2024

Proposed commit message

In scope of https://github.com/elastic/ingest-dev/issues/3254 - added MODULE env var definition for Go Integration tests to match same behavior as on Jenkins.
Jenkins vs. Buildkite comparison: https://gist.github.com/oakrizan/bf2aa5f1cd1ab01daa1184f471a99abc
BK build: https://buildkite.com/elastic/beats-xpack-dockerlogbeat/builds?branch=oakrizan%3Axpack-dockerlogbeat-fixes

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@oakrizan oakrizan added backport-v7.17.0 Automated backport with mergify backport-v8.13.0 Automated backport with mergify Team:Ingest-EngProd backport-v8.14.0 Automated backport with mergify labels Apr 26, 2024
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Apr 26, 2024
@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 26, 2024

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 13 min 38 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@oakrizan oakrizan marked this pull request as ready for review April 26, 2024 16:32
@oakrizan oakrizan requested a review from a team as a code owner April 26, 2024 16:32
@oakrizan oakrizan force-pushed the xpack-dockerlogbeat-fixes branch 5 times, most recently from 39eda9e to 8a7b899 Compare April 30, 2024 12:13
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basically LGTM; I've left a few comments to lowercase Dockerlogbeat reflecting the name (and helping GH keep the status checks properly sorted).

.buildkite/x-pack/pipeline.xpack.dockerlogbeat.yml Outdated Show resolved Hide resolved
.buildkite/x-pack/pipeline.xpack.dockerlogbeat.yml Outdated Show resolved Hide resolved
.buildkite/x-pack/pipeline.xpack.dockerlogbeat.yml Outdated Show resolved Hide resolved
.buildkite/x-pack/pipeline.xpack.dockerlogbeat.yml Outdated Show resolved Hide resolved
.buildkite/x-pack/pipeline.xpack.dockerlogbeat.yml Outdated Show resolved Hide resolved
.buildkite/x-pack/pipeline.xpack.dockerlogbeat.yml Outdated Show resolved Hide resolved
@oakrizan oakrizan force-pushed the xpack-dockerlogbeat-fixes branch 4 times, most recently from 9fd5c16 to 23c19d0 Compare May 7, 2024 07:12
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

left a small ask to change the name of the main packaging step to "Packaging" because it is packaging everything apart from Linux ARM.

.buildkite/x-pack/pipeline.xpack.dockerlogbeat.yml Outdated Show resolved Hide resolved
.buildkite/x-pack/pipeline.xpack.dockerlogbeat.yml Outdated Show resolved Hide resolved
@oakrizan oakrizan force-pushed the xpack-dockerlogbeat-fixes branch from 23c19d0 to 6a6ec63 Compare May 7, 2024 08:57
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oakrizan oakrizan force-pushed the xpack-dockerlogbeat-fixes branch from 6a6ec63 to 8ff67fe Compare May 7, 2024 12:02
@oakrizan oakrizan force-pushed the xpack-dockerlogbeat-fixes branch from 8ff67fe to 8e35975 Compare May 7, 2024 12:03
@oakrizan oakrizan merged commit b6b4280 into elastic:main May 8, 2024
108 checks passed
mergify bot pushed a commit that referenced this pull request May 8, 2024
…39235)

* added MODULE env var definition

* removed MODULE setup from common.sh

* updated pipeline and scripts

* pr fixes

* removed pipeline masking where irrelevant

* updated packaging step & gh notif names

(cherry picked from commit b6b4280)
mergify bot pushed a commit that referenced this pull request May 8, 2024
…39235)

* added MODULE env var definition

* removed MODULE setup from common.sh

* updated pipeline and scripts

* pr fixes

* removed pipeline masking where irrelevant

* updated packaging step & gh notif names

(cherry picked from commit b6b4280)
mergify bot pushed a commit that referenced this pull request May 8, 2024
…39235)

* added MODULE env var definition

* removed MODULE setup from common.sh

* updated pipeline and scripts

* pr fixes

* removed pipeline masking where irrelevant

* updated packaging step & gh notif names

(cherry picked from commit b6b4280)
oakrizan added a commit that referenced this pull request May 8, 2024
…39235)

* added MODULE env var definition

* removed MODULE setup from common.sh

* updated pipeline and scripts

* pr fixes

* removed pipeline masking where irrelevant

* updated packaging step & gh notif names

(cherry picked from commit b6b4280)
oakrizan added a commit that referenced this pull request May 9, 2024
…39235)

* added MODULE env var definition

* removed MODULE setup from common.sh

* updated pipeline and scripts

* pr fixes

* removed pipeline masking where irrelevant

* updated packaging step & gh notif names

(cherry picked from commit b6b4280)
oakrizan added a commit that referenced this pull request May 9, 2024
…39235)

* added MODULE env var definition

* removed MODULE setup from common.sh

* updated pipeline and scripts

* pr fixes

* removed pipeline masking where irrelevant

* updated packaging step & gh notif names

(cherry picked from commit b6b4280)
oakrizan added a commit that referenced this pull request May 9, 2024
…39235)

* added MODULE env var definition

* removed MODULE setup from common.sh

* updated pipeline and scripts

* pr fixes

* removed pipeline masking where irrelevant

* updated packaging step & gh notif names

(cherry picked from commit b6b4280)
oakrizan added a commit that referenced this pull request May 9, 2024
…39235) (#39457)

* added MODULE env var definition

* removed MODULE setup from common.sh

* updated pipeline and scripts

* pr fixes

* removed pipeline masking where irrelevant

* updated packaging step & gh notif names

(cherry picked from commit b6b4280)

Co-authored-by: Olga Naydyonock <olga.naidjonoka@elastic.co>
oakrizan added a commit that referenced this pull request May 9, 2024
…39235) (#39458)

* added MODULE env var definition

* removed MODULE setup from common.sh

* updated pipeline and scripts

* pr fixes

* removed pipeline masking where irrelevant

* updated packaging step & gh notif names

(cherry picked from commit b6b4280)

Co-authored-by: Olga Naydyonock <olga.naidjonoka@elastic.co>
oakrizan added a commit that referenced this pull request May 9, 2024
…39235) (#39459)

* added MODULE env var definition

* removed MODULE setup from common.sh

* updated pipeline and scripts

* pr fixes

* removed pipeline masking where irrelevant

* updated packaging step & gh notif names

(cherry picked from commit b6b4280)

Co-authored-by: Olga Naydyonock <olga.naidjonoka@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v7.17.0 Automated backport with mergify backport-v8.13.0 Automated backport with mergify backport-v8.14.0 Automated backport with mergify Team:Ingest-EngProd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants