Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7.17 backport] Update elastic-agent-client used in 7.17 releases #39224

Merged
merged 4 commits into from May 7, 2024
Merged

[7.17 backport] Update elastic-agent-client used in 7.17 releases #39224

merged 4 commits into from May 7, 2024

Conversation

michel-laterman
Copy link
Contributor

@michel-laterman michel-laterman commented Apr 25, 2024 •
edited

Proposed commit message

Update the elastic-agent-client to the latest tagged release.
Update protobuf libraries.
elastic-agent will have v2 related functions disabled.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Apr 25, 2024
@michel-laterman michel-laterman changed the title Update elastic-agent-client used in 7.17 releases [7.17 backport] Update elastic-agent-client used in 7.17 releases Apr 25, 2024
@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 25, 2024 •
edited

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2024-05-06T15:36:13.833+0000

  • Duration: 138 min 56 sec

Test stats 🧪

Test Results
Failed 0
Passed 20613
Skipped 1423
Total 22036

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@michel-laterman michel-laterman force-pushed the 7.17-update-elastic-agent-client branch 2 times, most recently from f889fec to 6a5f9bc Compare April 26, 2024 20:28
@michel-laterman michel-laterman force-pushed the 7.17-update-elastic-agent-client branch 3 times, most recently from 19c7d68 to 3f9f7b0 Compare April 26, 2024 22:14
@michel-laterman michel-laterman force-pushed the 7.17-update-elastic-agent-client branch from 3f9f7b0 to ee0b705 Compare April 26, 2024 22:46
michel-laterman
michel-laterman commented Apr 26, 2024
View reviewed changes
x-pack/elastic-agent/pkg/core/server/server.go
@@ -148,6 +153,7 @@ func (s *Server) Start() error {
if ok := certPool.AppendCertsFromPEM(s.ca.Crt()); !ok {
return errors.New("failed to append root CA", errors.TypeSecurity)
}
//nolint:gosec // G402: TLS MinVersion too low.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also set MinVersion if we don't want to disable the linter here

@michel-laterman michel-laterman marked this pull request as ready for review May 3, 2024 16:01
@michel-laterman michel-laterman requested review from a team as code owners May 3, 2024 16:01
@michel-laterman michel-laterman requested review from michalpristas and pchila and removed request for a team May 3, 2024 16:01
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@cmacknz
Copy link
Member

cmacknz commented May 6, 2024

To double check, Fleet server was confirmed to bootstrap with these changes?

@michel-laterman
Copy link
Contributor Author

Yes, last time i tested it bootstrapped locally correctly. We can also try to make a custom issue and check on ESS as well.

blakerouse
blakerouse approved these changes May 7, 2024
View reviewed changes
Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

proto.StartUpInfo is backwards compatible, looks good.

@michel-laterman michel-laterman merged commit bb37b42 into elastic:7.17 May 7, 2024
185 checks passed
@michel-laterman michel-laterman deleted the 7.17-update-elastic-agent-client branch May 7, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakerouse blakerouse blakerouse approved these changes

@michalpristas michalpristas Awaiting requested review from michalpristas michalpristas is a code owner automatically assigned from elastic/elastic-agent-control-plane

@pchila pchila Awaiting requested review from pchila pchila is a code owner automatically assigned from elastic/elastic-agent-control-plane

@AndersonQ AndersonQ Awaiting requested review from AndersonQ AndersonQ is a code owner automatically assigned from elastic/elastic-agent-data-plane

@faec faec Awaiting requested review from faec faec is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@michel-laterman michel-laterman

Labels
dependency Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team technical debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@michel-laterman @elasticmachine @cmacknz @blakerouse