Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.14](backport #39165) [Eleasticsearch] Remove hidden field from indice metricset docs #39220

Merged
merged 1 commit into from Apr 29, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Apr 25, 2024

Proposed commit message

This PR removes the hidden flag introduced by #18639. The SM UI doesn't use this flag, and retrieving which indices are hidden is an expensive operation that can sometimes cause problems such as timeouts depending on how large a cluster is.

elasticsearch": {
  "cluster": {
    "id": "5QYQ1YeeRjy9MJtahqzY6w",
    "name": "elasticsearch"
  },
  "index": {
    "status": "green",
    "hidden": false,
    "shards": {
      "total": 1,
      "primaries": 1
    }

   ...
  }
  ...
}
"elasticsearch": {
  "cluster": {
    "id": "5QYQ1YeeRjy9MJtahqzY6w",
    "name": "elasticsearch"
  },
  "index": {
    "status": "green",
    "shards": {
      "total": 1,
      "primaries": 1
    }
   ...
  }
 ...
}

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

  • Start a local ES and kibana instances
  • Start metricbeat with elasticsearch module enabled
  • Run the query below and check if there is no hidden field in the index object
GET .monitoring-es-*,metrics-*/_search
{
  "size": 5,
  "query": {
    "bool": {
      "filter": [
        {
          "bool": {
            "should": [
              {
                "term": {
                  "data_stream.dataset": "elasticsearch.stack_monitoring.index"
                }
              },
              {
                "term": {
                  "metricset.name": "index"
                }
              },
              {
                "term": {
                  "type": "index_stats"
                }
              }
            ]
          }
        },
        {
          "range": {
            "timestamp": {
              "gte": "now-15m",
              "lte": "now"
            }
          }
        }
      ]
    }
  },
  "collapse": {
    "field": "index_stats.index",
    "inner_hits": {
      "name": "earliest",
      "size": 1,
      "sort": [
        {
          "timestamp": {
            "order": "asc",
            "unmapped_type": "long"
          }
        }
      ]
    }
  },
  "sort": [
    {
      "timestamp": {
        "order": "desc",
        "unmapped_type": "long"
      }
    }
  ]
}

Related issues

closes #39161


This is an automatic backport of pull request #39165 done by [Mergify](https://mergify.com).

…9165)

* Remove  field

* fix lint and tests

* remove hidden from Index struct

* more lint

* Update CHANGELOG

* More lint stuff and test

(cherry picked from commit de23b1a)
@mergify mergify bot requested a review from a team as a code owner April 25, 2024 15:47
@mergify mergify bot added the backport label Apr 25, 2024
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Apr 25, 2024
@botelastic
Copy link

botelastic bot commented Apr 25, 2024

This pull request doesn't have a Team:<team> label.

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 103 min 37 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Contributor Author

mergify bot commented Apr 29, 2024

This pull request has not been merged yet. Could you please review and merge it @crespocarlos? 🙏

@crespocarlos crespocarlos merged commit 54cc3cb into 8.14 Apr 29, 2024
37 checks passed
@crespocarlos crespocarlos deleted the mergify/bp/8.14/pr-39165 branch April 29, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants