Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update xpack/filebeat & xpack/metricbeat pipelines to match Jenkins steps #39211

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

oakrizan
Copy link
Contributor

@oakrizan oakrizan commented Apr 25, 2024

Proposed commit message

In scope of https://github.com/elastic/ingest-dev/issues/3254 - updated x-pack/filebeat and x-pack/metricbeat pipelines to match same steps & commands as in Jenkins.

Jenkins vs. Buildkite comparison

BK builds:

For both pipelines updated cloud test environment setup script and test commands to match Jenkins.

x-pack/filebeat: Cloud (MODULE) Tests failure is not related to current PR changes.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Apr 25, 2024
Copy link
Contributor

mergify bot commented Apr 25, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @oakrizan? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@oakrizan oakrizan added :Windows macOS Enable builds in the CI for darwin testing arm Enable builds in the CI for ARM testing labels Apr 25, 2024
@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 25, 2024

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2024-05-09T11:57:24.624+0000

  • Duration: 12 min 13 sec

Test stats 🧪

Test Results
Failed 0
Passed 2
Skipped 0
Total 2

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@oakrizan oakrizan force-pushed the xpack-filebeat-fixes branch 2 times, most recently from e243fad to 80030ff Compare April 26, 2024 08:01
@oakrizan oakrizan force-pushed the xpack-filebeat-fixes branch 2 times, most recently from 1603b3a to 56bfd94 Compare April 26, 2024 15:08
@oakrizan oakrizan added backport-v7.17.0 Automated backport with mergify backport-v8.13.0 Automated backport with mergify Team:Ingest-EngProd backport-v8.14.0 Automated backport with mergify labels Apr 26, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Apr 26, 2024
@oakrizan oakrizan marked this pull request as ready for review April 26, 2024 16:37
@oakrizan oakrizan requested a review from a team as a code owner April 26, 2024 16:37
@oakrizan oakrizan force-pushed the xpack-filebeat-fixes branch 2 times, most recently from 2f39742 to 360f65a Compare April 29, 2024 08:19
@oakrizan oakrizan added the aws Enable builds in the CI for aws cloud testing label Apr 29, 2024
@oakrizan oakrizan force-pushed the xpack-filebeat-fixes branch 3 times, most recently from 8a65cc2 to 0cc6b2c Compare April 30, 2024 14:31
@oakrizan oakrizan force-pushed the xpack-filebeat-fixes branch 3 times, most recently from 9369701 to 0898738 Compare May 1, 2024 09:03
@oakrizan
Copy link
Contributor Author

oakrizan commented May 1, 2024

/test

Copy link
Contributor

mergify bot commented May 1, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b xpack-filebeat-fixes upstream/xpack-filebeat-fixes
git merge upstream/main
git push upstream xpack-filebeat-fixes

@oakrizan oakrizan force-pushed the xpack-filebeat-fixes branch 5 times, most recently from 7710f78 to 272fc14 Compare May 7, 2024 09:01
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I'd really like to avoid adding a new script (aws_cloud_tests.sh) and given that it does very little different to the existing one, requested a change/left a suggestion

.buildkite/scripts/aws_cloud_tests.sh Outdated Show resolved Hide resolved
.buildkite/x-pack/pipeline.xpack.filebeat.yml Outdated Show resolved Hide resolved
@oakrizan oakrizan changed the title Update xpack/filebeat pipeleine to match Jenkins steps Update xpack/filebeat & xpack/metricbeat pipelines to match Jenkins steps May 8, 2024
@oakrizan oakrizan force-pushed the xpack-filebeat-fixes branch 4 times, most recently from 45b64b0 to 2391dbe Compare May 8, 2024 11:01
@oakrizan oakrizan requested a review from dliappis May 8, 2024 12:25
Copy link
Contributor

mergify bot commented May 10, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b xpack-filebeat-fixes upstream/xpack-filebeat-fixes
git merge upstream/main
git push upstream xpack-filebeat-fixes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
arm Enable builds in the CI for ARM testing aws Enable builds in the CI for aws cloud testing backport-v7.17.0 Automated backport with mergify backport-v8.13.0 Automated backport with mergify backport-v8.14.0 Automated backport with mergify macOS Enable builds in the CI for darwin testing Team:Ingest-EngProd :Windows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants