Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix function names in comment #38800

Merged
merged 3 commits into from Apr 30, 2024
Merged

Conversation

goodfirm
Copy link
Contributor

@goodfirm goodfirm commented Apr 10, 2024

Docs

Proposed commit message

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

Signed-off-by: goodfirm <fanyishang@yeah.net>
@goodfirm goodfirm requested a review from a team as a code owner April 10, 2024 06:01
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Apr 10, 2024
Copy link

cla-checker-service bot commented Apr 10, 2024

💚 CLA has been signed

Copy link
Contributor

mergify bot commented Apr 10, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @goodfirm? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@pierrehilbert pierrehilbert added the Team:Elastic-Agent Label for the Agent team label Apr 10, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Apr 10, 2024
@pierrehilbert
Copy link
Collaborator

Hello @goodfirm
Thanks for contributing to our project.
Could you please sign our CLA?

@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 10, 2024

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2024-04-28T12:55:46.793+0000

  • Duration: 175 min 6 sec

Test stats 🧪

Test Results
Failed 0
Passed 29399
Skipped 2061
Total 31460

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@goodfirm
Copy link
Contributor Author

Hello @goodfirm Thanks for contributing to our project. Could you please sign our CLA?

Of course.

Done

@goodfirm
Copy link
Contributor Author

Anything need I to do? Please feel free to tell me.

@pierrehilbert
Copy link
Collaborator

I just restarted the CI, if everything is green, we should be good to go.
Thx for your contribution @goodfirm

@goodfirm
Copy link
Contributor Author

I just restarted the CI, if everything is green, we should be good to go. Thx for your contribution @goodfirm

friendly ping~

@ycombinator ycombinator added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Apr 29, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@pierrehilbert pierrehilbert merged commit 6bb2a82 into elastic:main Apr 30, 2024
89 of 91 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Elastic-Agent Label for the Agent team Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants