Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: avoid test crash getting @elastic/elasticsearch version #2351

Merged
merged 1 commit into from
Sep 27, 2021

Conversation

trentm
Copy link
Member

@trentm trentm commented Sep 27, 2021

The tests were using require('@elastic/elasticsearch/package.json')
which runs afoul of EOL'd folder mappings in "exports"
(https://nodejs.org/api/all.html#DEP0148) with current ES client
versions and the latest node v17 nightly.

Fixes: #2350

Checklist

The tests were using `require('@elastic/elasticsearch/package.json')`
which runs afoul of EOL'd folder mappings in "exports"
(https://nodejs.org/api/all.html#DEP0148) with current ES client
versions and the latest node v17 nightly.

Fixes: #2350
@trentm trentm self-assigned this Sep 27, 2021
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Sep 27, 2021
@elastic-apm-tech elastic-apm-tech added this to In Progress in APM-Agents (OLD) Sep 27, 2021
@apmmachine
Copy link
Collaborator

apmmachine commented Sep 27, 2021

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2021-09-27T19:39:36.570+0000

  • Duration: 22 min 39 sec

  • Commit: 8e61dbd

Test stats 🧪

Test Results
Failed 0
Passed 6
Skipped 4
Total 10

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • run module tests for <modules> : Run TAV tests for one or more modules, where <modules> can be either a comma separated list of modules (e.g. memcached,redis) or the string literal ALL to test all modules

  • run benchmark tests : Run the benchmark test only.

@trentm
Copy link
Member Author

trentm commented Sep 27, 2021

I manually did an edge run to test again with the latest Node.js nightly and that passed: https://apm-ci.elastic.co/blue/organizations/jenkins/apm-agent-nodejs%2Fapm-agent-nodejs-mbp/detail/PR-2351/2/pipeline/189

@trentm trentm requested a review from astorm September 27, 2021 20:10
Copy link
Contributor

@astorm astorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 does what it says it does, and keeps up up to date with the node.js release train. Approving.

@@ -162,6 +162,7 @@
"memcached": "^2.2.2",
"mimic-response": "^2.1.0",
"mkdirp": "^0.5.1",
"module-details-from-path": "^1.0.3",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 for this being in devDependencies

@trentm trentm merged commit d894e3c into master Sep 27, 2021
@trentm trentm deleted the trentm/esclient-path-not-exported-2350 branch September 27, 2021 22:20
APM-Agents (OLD) automation moved this from In Progress to Done Sep 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-nodejs Make available for APM Agents project planning.
Projects
3 participants