New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Repairing setext heading support, certain uses of backticks after GitHub API format changes #145
Repairing setext heading support, certain uses of backticks after GitHub API format changes #145
Conversation
Github must have changed something on their end, the HTML seems to have changed a little.
I think this is working now. It includes #144 out of necessity. |
@ekalinin I think I took this about as far as I can - all of the remote tests fail. I copied one of the non-english README's over into a local test to show that it still can pass, but the |
Thanks for the patch! |
Hey @ekalinin I've fixed the conflicts - hopefully the number of tests failing is similar to in pull/144. Should actually be one fewer I believe. |
@ekalinin so yeah, the remote tests are all still failing but all the local ones are passing, including the new ones. The remote ones might be some effort to get them working again. |
This must be applied on top of #144 (Thanks @jkburges!) but when I tried that PR locally, I realized the setext headings (https://github.github.com/gfm/#setext-heading) are broken.
What I'm getting is
renders as
* [](#title-2)
when it should be something like* [<em>Title 2</em>](#title-2)
prior to Github's reformatting.I later realized that some usages for backticks (which generate as the
<code>
tag) get put on a newline, breaking the parsing.