Use var(--color) as base color for code tag #64
Conversation
There are some Zola highlight themes and syntax definitions that don't work very well, and as such, they sometimes fall back to the base text color provided by the Zola theme. If the base text color is not neutral, e.g. white or black, the code highlighting can look quite terrible, as shown in getzola/zola#1423. It would be nice if the `code` tag defaulted to `var(--color)` instead of `var(--accent)` to avoid breaking several built-in Zola highlight themes. With that said, if there's enough opposition to this change, it's okay; I'm willing to just override the CSS in my own project to fix the highlight themes.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Looks like Vercel is failing due to a deprecated Node version: Seems to be unrelated to this PR, but I just thought I'd point this out. |
|
@ejmg Just wanted to send a gentle ping requesting a review. Sorry to do this directly; I only wanted to let you know this PR has been waiting for a while, just in case it might've fallen through the cracks. Don't mean to be a bother; any feedback would be appreciated. Thanks! ❤️ |
|
@ebkalderon you are totally fine to ping me; tbqh, i have already told other potential contributors that I would get around to their PR's and failed to do so. i am blocking tonight and portions of this weekend to at least update the deployment and zerm's zola version and, hopefully, most of these PRs. |
There are some Zola highlight themes and syntax definitions that don't work very well, and as such, they sometimes fall back to the base text color provided by the Zola theme. If the base text color is not neutral, e.g. white or black, the code highlighting can look quite terrible, as shown in getzola/zola#1423.
It would be nice if the
codetag defaulted tovar(--color)instead ofvar(--accent)to avoid breaking several built-in Zola highlight themes, e.g.charcoalon Zola 0.16.1. With that said, if there's enough opposition to this change, it's okay; I'm willing to just override the CSS in my own project to fix the highlight themes.