Support inlining CSS for a performance boost. #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Can reduce First Content Paint time and overall download size for a single page. This is useful for sites where often only one page is visited by a user. In such a case, separately loading/caching the CSS provides no extra benefit, and slows down content rendering while waiting the CSS network request to start and finish. Additionally, when using a decent compression algorithm like Brotli, the total number of bytes sent over the wire can drop a bit. In my testing, I saw total CSS + HTML size drop by 0.17KB, or ~2.5%. Original idea taken from "Lightspeed" Zola theme: https://github.com/carpetscheme/lightspeed/blob/master/templates/index.html#L15-L16
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/ejmg/zerm/iVr2zWW3n1cUzWfmzNqXq8DnTpV6 |
ejmg
reviewed
Jul 17, 2021
Co-authored-by: elias <elias.jm.garcia@gmail.com>
|
whoops, looks like merging #20 gave a conflict. if you get the chance to resolve it, we're good to close up your final outstanding PR! |
|
Sounds good - will fix this conflict in the next few days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can reduce First Content Paint time and overall download size for a
single page. This is useful for sites where often only one page is
visited by a user. In such a case, separately loading/caching the CSS
provides no extra benefit, and slows down content rendering while
waiting the CSS network request to start and finish.
Additionally, when using a decent compression algorithm like Brotli, the
total number of bytes sent over the wire can drop a bit. In my testing,
I saw total CSS + HTML size drop by 0.17KB, or ~2.5%.
Original idea taken from "Lightspeed" Zola theme:
https://github.com/carpetscheme/lightspeed/blob/master/templates/index.html#L15-L16