Add right-to-left layout support #10
Conversation
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/ejmg/zerm/4dn97bfPNgmzfwzmWZadrPvU9prM |
|
Thank you so much for the PR.
This is a really awesome PR, especially since I don’t have any knowledge on
RTL in terms of both styling and the web.
Do you have some example rendering shots of the theme I could see? Ideally,
we would figure out how to get Vercel to deploy two sites on updates/PRs
after this one to make sure that neither LTR or RTL are noticeably
regressed.
…On Sat, Jan 23, 2021 at 8:19 AM vercel[bot] ***@***.***> wrote:
This pull request is being automatically deployed with Vercel (learn more
<https://vercel.link/github-learn-more>).
To see the status of your deployment, click below or on the icon next to
each commit.
🔍 Inspect: https://vercel.com/ejmg/zerm/1l4gix01x
✅ Preview: *In Progress*
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#10 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEK7ZPTCD6H2AIHZHWJKJXDS3LLHVANCNFSM4WPW42EA>
.
|
|
Here you go. Also I did some |
Importing a SCSS file containing rules results in duplication of styles, and one can verify this by looking at the browser's style inspection tool. This commit extracts rules from _variables.scss into _root.scss.
|
Why is this hanging around for so long? |
|
because between my job and all the other PR's that have come through, i've unfortunately left this one behind. i'll try to make a point of reviewing this PR on the weekend. what i said before about this PR remains true, your effort and time is truly appreciated 🙂 |
You can use this by setting
config.extra.rtltotrue.