Preliminary Python API #240
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejgallego
force-pushed
the
v8.13+pyml
branch
4 times, most recently
from
cfb85a3
to
057ac93
Compare
ejgallego
force-pushed
the
v8.13+pyml
branch
from
057ac93
to
e6260a9
Compare
ejgallego
force-pushed
the
v8.13+pyml
branch
4 times, most recently
from
cdda614
to
48f4936
Compare
We add Python serialization for the complete protocol, modulo the existing issues the current setup seems to work well! Main hiccup was the lack of variants support janestreet/ppx_python#4 , but fortunately it is easy to work around. Thanks to the `ppx_python` team for their quick resolution of issue janestreet/ppx_python#1 which was essential to get this commit working.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[serlib] Add ppx_python serialization.
We add Python serialization for the complete protocol, modulo the
existing issues the current setup seems to work well!
Main hiccup was the lack of variants support
janestreet/ppx_python#4 , but fortunately it
was easy to work around.
Thanks to the
ppx_pythonteam for their quick resolution of issuejanestreet/ppx_python#1 which was essential
to get this commit working.
This PR just takes care of the serialization, main Python support is
done now in https://github.com/ejgallego/pycoq
Thus, this PR closes #48