[CDR-1397] Add AQL/SQL debug option #1296
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robot Results
|
alexlehn
force-pushed
the
feature/CDR-1397-add-aql-debug-option
branch
13 times, most recently
from
2192898
to
19fb3bd
Compare
|
@alexlehn - Before merging to develop branch, below changes should be done:
|
alexlehn
force-pushed
the
feature/CDR-1397-add-aql-debug-option
branch
from
c8f9385
to
6b183b9
Compare
alexlehn
force-pushed
the
feature/CDR-1397-add-aql-debug-option
branch
2 times, most recently
from
4531ea4
to
47c1482
Compare
vidi42
previously requested changes
May 14, 2024
alexlehn
commented
May 15, 2024
rest-openehr/src/test/java/org/ehrbase/rest/openehr/OpenehrQueryControllerTest.java
Show resolved
Hide resolved
alexlehn
commented
May 15, 2024
rest-openehr/src/main/java/org/ehrbase/rest/openehr/OpenehrQueryController.java
Show resolved
Hide resolved
rest-openehr/src/main/java/org/ehrbase/rest/openehr/OpenehrQueryController.java
Show resolved
Hide resolved
rest-openehr/src/test/java/org/ehrbase/rest/openehr/OpenehrQueryControllerTest.java
Show resolved
Hide resolved
…y checks in feature branch
- set meta.schemaVersion to 1.0.3 - introduced request-scoped AqlQueryContext - introduced config setting ehrbase.rest.aql.response.executed-aql-enabled - renamed config setting ehrbase.rest.aql.response.execution-options-enabled to ehrbase.rest.aql.debugging-enabled TODO fix OpenehrQueryControllerTest
alexlehn
force-pushed
the
feature/CDR-1397-add-aql-debug-option
branch
from
3f4b3c2
to
486bbd3
Compare
alexlehn
force-pushed
the
feature/CDR-1397-add-aql-debug-option
branch
from
486bbd3
to
5fa9e65
Compare
HolgerReiseVSys
approved these changes
May 17, 2024
HolgerReiseVSys
requested review from
HolgerReiseVSys
and removed request for
vidi42
HolgerReiseVSys
approved these changes
May 17, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add AQL debug option support. Extended the
AqlRequestobject withAqlExecutionOptionto pass down the debugging options to theAqlService. Extracted theAqlRepositoryquery building from the actual execution to be able to perform a dry-run and/or provide the query plan.The debug option support is disabled by default and needs to be switched on using
ehrbase.rest.aql.response.execution-options-enabled=true.Debug options are Provided as header
Pre-Merge checklist