Build ehrbase image using jlink with custom jre #1285
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexlehn
force-pushed
the
feature/tweak-docker-image
branch
4 times, most recently
from
cf98856
to
5b44f3e
Compare
Robot Results
|
alexlehn
force-pushed
the
feature/tweak-docker-image
branch
9 times, most recently
from
7ab3526
to
4bce184
Compare
|
alexlehn
force-pushed
the
feature/tweak-docker-image
branch
from
4bce184
to
7656fb3
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Switch to a multistage docker build that uses jlink to create a custom jre for ehrbase. The final image is now based on a simple alpine base image with an extracted spring jar and reduced jre. Further more the slimmer image contains less installed libs and tools as well as a stripped down jvm, what makes it less vulnerability.
As a side efect the bootup time is also decreased because ehrbase is not started as a fat jar any more.
Image size change
bootup time (rough average on my machine ;)
wgetis still available in case someone needs to perform som healthcheck commands.Pre-Merge checklist