Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update helper.py: removed full path of main script as it should be re… #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mubbashir
Copy link

removed full path of main script as it should be re as it should be relative to avoid resource loading failures

@mubbashir
Copy link
Author

It more of a problem when output dir is not an absolute path hence adding f"{output}/index.js" will result in broken paths

@eggachecat
Copy link
Owner

Hi @mubbashir thanks for the PR.

But I don't understand the change actually: with the PR, I don't think function dump_html_output will work anymore, since now main_script_path is undefined.

Are you refering to something like os.path.join(output, 'index.js') , which makes more sense. The original string concatation for path join is a bad practice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants