Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: modify order history to use human readable number #207

Merged
merged 12 commits into from May 8, 2024
Merged

feat: modify order history to use human readable number #207

merged 12 commits into from May 8, 2024

Conversation

nyujacky
Copy link
Contributor

@nyujacky nyujacky commented Apr 19, 2024 •
edited by grmartin

No description provided.

@nyujacky nyujacky marked this pull request as draft April 19, 2024 23:26
@nyujacky nyujacky marked this pull request as ready for review April 22, 2024 21:47
@nyujacky
Copy link
Contributor Author

Not sure if the call to get order should be changed as well, to get_order_by_number(order_number=order_number) since it currently uses get_order_by_id(order_id=order_number) where order number is cart-id-### (old order number)

shafqatfarhan
shafqatfarhan reviewed Apr 23, 2024
View reviewed changes
Copy link
Member

@shafqatfarhan shafqatfarhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a few comments here and over Slack as well. Please have a look. Thanks.

commerce_coordinator/apps/commercetools/data.py Outdated Show resolved Hide resolved
commerce_coordinator/apps/commercetools/data.py Outdated Show resolved Hide resolved
@nyujacky nyujacky force-pushed the jng/SONIC-329_modify_order_history branch from 0419fe0 to 566d195 Compare April 29, 2024 15:47
@nyujacky nyujacky marked this pull request as draft April 29, 2024 17:23
@nyujacky nyujacky marked this pull request as ready for review April 29, 2024 20:00
@nyujacky nyujacky marked this pull request as draft April 29, 2024 20:00
@nyujacky nyujacky force-pushed the jng/SONIC-329_modify_order_history branch from 0b51902 to c1c3994 Compare April 30, 2024 22:24
@nyujacky nyujacky marked this pull request as ready for review May 2, 2024 20:05
@nyujacky nyujacky force-pushed the jng/SONIC-329_modify_order_history branch from bbeede2 to eed588a Compare May 3, 2024 13:00
@nyujacky nyujacky requested a review from grmartin May 3, 2024 13:01
shafqatfarhan
shafqatfarhan approved these changes May 6, 2024
View reviewed changes
commerce_coordinator/apps/commercetools/pipeline.py Outdated Show resolved Hide resolved
commerce_coordinator/apps/commercetools/pipeline.py Outdated Show resolved Hide resolved
commerce_coordinator/apps/commercetools/pipeline.py Outdated Show resolved Hide resolved
commerce_coordinator/settings/base.py Outdated Show resolved Hide resolved
@nyujacky nyujacky force-pushed the jng/SONIC-329_modify_order_history branch from fb93739 to 645f3a9 Compare May 6, 2024 13:33
@shafqatfarhan shafqatfarhan deleted the jng/SONIC-329_modify_order_history branch May 7, 2024 10:39
@shafqatfarhan shafqatfarhan restored the jng/SONIC-329_modify_order_history branch May 7, 2024 10:40
@shafqatfarhan shafqatfarhan reopened this May 7, 2024
@shafqatfarhan shafqatfarhan force-pushed the jng/SONIC-329_modify_order_history branch from d9e6c1f to fc2bbc2 Compare May 7, 2024 10:46
@shafqatfarhan shafqatfarhan force-pushed the jng/SONIC-329_modify_order_history branch from 2c5e799 to 5ef2ce5 Compare May 7, 2024 13:54
@grmartin grmartin merged commit 4f15433 into main May 8, 2024
9 checks passed
@grmartin grmartin deleted the jng/SONIC-329_modify_order_history branch May 8, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grmartin grmartin grmartin approved these changes

@shafqatfarhan shafqatfarhan shafqatfarhan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@nyujacky @grmartin @shafqatfarhan