Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BD-46] feat: change outline primary btn color #78

Draft
wants to merge 1 commit into
base: alpha
Choose a base branch
from

Conversation

khudym
Copy link

@khudym khudym commented Oct 11, 2023

Changed border color for outline-primary button
Issue

@openedx-webhooks
Copy link

openedx-webhooks commented Oct 11, 2023

Thanks for the pull request, @khudym!

This is currently a draft pull request. When it is ready for our review and all tests are green, click "Ready for Review", or remove "WIP" from the title, as appropriate.

Thanks for your pull request, but this repo does not accept outside contributions unless they are under contract. If you think this is an error, please contact @nedbat.

@adamstankiewicz
Copy link
Member

@khudym I believe we will want this change not only on the alpha branch, but also on master so consuming applications can start using this style update now?

@khudym
Copy link
Author

khudym commented Dec 28, 2023

@khudym I believe we will want this change not only on the alpha branch, but also on master so consuming applications can start using this style update now?
Yes, of course, but i have a question, according to the design, the outline for the brand button looks a little inconsistent. When focused, it does not have a double border, like the primary button, the disabled is not visible at all. Maybe its color should also be changed?

figma-button

@khudym khudym marked this pull request as draft December 29, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants