[BD-46]: style names were updated #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, @Inferato! When this pull request is ready, tag your edX technical lead. |
10 tasks
Comment on lines
+382
to
+385
| $box-shadow-down-1: 0px 2px 8px 0px rgba(0,0,0,0.15), 0px 2px 4px 0px rgba(0,0,0,0.15); | ||
| $box-shadow-down-2: 0px 4px 10px 0px rgba(0,0,0,0.15), 0px 8px 16px 0px rgba(0,0,0,0.15); | ||
| $box-shadow-down-3: 0px 8px 20px 0px rgba(0,0,0,0.15), 0px 10px 20px 0px rgba(0,0,0,0.15); | ||
| $box-shadow-down-4: 0px 8px 48px 0px rgba(0,0,0,0.15), 0px 20px 40px 0px rgba(0,0,0,0.15); |
There was a problem hiding this comment.
Similar to how we kept the original $level-X-box-shadow SCSS variables in the core Paragon theme for backwards compatibility, we may want to also leave the original variable definitions here, with a comment that their usage is deprecated.
Maybe something along the lines of:
$box-shadow-down-1: 0px 2px 8px 0px rgba(0,0,0,0.15), 0px 2px 4px 0px rgba(0,0,0,0.15);
// deprecated in favor of `$box-shadow-{side}-{level}`
$level-1-box-shadow: $box-shadow-down-1;
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a result of openedx/paragon#1385
$level-{level}-box-shadowscss variables have been reamed to$box-shadow-down-{level}, these changes need to reflected i edx.org theme repositoryAC
$level-{level}-box-shadowscss variables have toto$box-shadow-down-{level}