feat: add paragon theme support #35
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidjoy
reviewed
May 18, 2021
| @@ -0,0 +1,280 @@ | |||
| const applyTheme = (oldTheme) => { | |||
There was a problem hiding this comment.
Hmm, I expect that this manual deep merge could actually be done in ParagonProvider where it's setting up its ThemeProvider components, rather than here. That way the theme itself would just be a sparse object, minus the merging logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building on Adam's PR, this set up an applyTheme method in theme.js that copies over the css variable values in paragon/_variables.scss and merges them on top of the paragon theme object.