Modify local TunnelKit's handling of hasBetterPath using NWPathMonitor #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roop
changed the title
roop
requested review from
johankool and
jeroenleenarts
and removed request for
johankool
jeroenleenarts
approved these changes
Sep 21, 2020
johankool
approved these changes
Sep 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is intended to fix #311, but it's not clear yet whether it actually fixes it.
This uses NWPathMonitor to figure out when a hasBetterPath change should trigger a reconnection. Since I've not been able to reproduce the reconnection issue well, I've implemented what I think would be a fix, without really being able to verify that it works. So, this PR is made against a new "experimental" branch instead of master. Once merged to "experimental" after review, @efef can build with that and verify the fix.
This PR also exposes an option in the app's Preferences to turn the fix on/off.