Skip to content
This repository has been archived by the owner on Jul 28, 2020. It is now read-only.

Fixed markdown #4366

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed markdown #4366

wants to merge 2 commits into from

Conversation

justinachua
Copy link

Application to the Class of 2020πŸŽ“

This pull request template helps you complete an application to the Class of 2020. Use the checklist below to verify you have followed the instructions correctly.

Checklist βœ…

  • [ x] I have read the instructions on the README file before submitting my application.
  • [x ] I made my submission by creating a folder on the _data folder and followed the naming convention mentioned in the instructions (<username>), added my profile picture and markdown file.
  • [x ] I have used the Markdown file template to add my information to the Year Book.
  • [ x] I understand that a reviewer will merge my pull request after examining it or ask for changes in case needed.
  • x[ ] I understand I should not tag or add a reviewer to this Pull Request.
  • [x ] I understand the photo added to the template will be used in the ceremony "Graduate Walk".
  • [x ] I have added the event to my Calendar.

Copy link
Contributor

@Mohammed-Shoaib Mohammed-Shoaib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @justinachua,

Congrats on graduating! πŸŽ“ πŸŽ‰

You haven't added your information! πŸ™… You need to have the following 2 files:

  1. A markdown file
  2. A profile image

Although you do have the markdown file, it's empty. Please read instructions on the README file for more information.

Unfortunately, the image is not squared (1:1 or width = height) πŸ”³ The size of the image is 3004x3008 (pixels).

Lastly, the checklist hasn't been marked properly. We cannot add your information to the yearbook without your permission. You can edit your comment and mark the task list by changing [ ] to [x] (without spaces). Please refer here for more information.

Could you please make these changes? πŸ“

Thanks,
Mohammed Shoaib

Copy link
Contributor

@juanpflores juanpflores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have reviewed πŸ“ your application to the yearbook. It looks great ✨ but we found that some headers might be missing in the Markdown file or the format is broken (used any non-ascii characters?). I will close this PR so you can do the changes requested. You can open a new one once you've done the fixes and we will review it again.😊

@juanpflores juanpflores reopened this Jun 12, 2020
@juanpflores juanpflores self-requested a review June 12, 2020 00:45
Copy link
Contributor

@juanpflores juanpflores left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need you to add the content on the markdown file before accepting your pull request

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants