Skip to content
This repository has been archived by the owner on Jul 28, 2020. It is now read-only.

Final Changes #4057

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Final Changes #4057

wants to merge 13 commits into from

Conversation

paras1810
Copy link

@paras1810 paras1810 commented May 26, 2020

Application to the Class of 2020πŸŽ“

This pull request template helps you complete an application to the Class of 2020. Use the checklist below to verify you have followed the instructions correctly.

Checklist βœ…

  • I have read the instructions on the README file before submitting my application.
  • I made my submission by creating a folder on the _data folder and followed the naming convention mentioned in the instructions (<username>), added my profile picture and markdown file.
  • I have used the Markdown file template to add my information to the Year Book.
  • I have completed the form: https://airtable.com/shrmuHxu38ZariKJi
  • My application belongs to:
    • Tier 1 πŸ“–: I added myself to the Year Book.
    • Tier 2 ✏️: I wrote a post on DEV about a project I built.
    • Tier 3 ✨: I want my project to be highlighted on stream.
  • I understand that a reviewer will merge my pull request after examining it or ask for changes in case needed.
  • I understand I should not tag or add a reviewer to this Pull Request.
  • I understand the photo added to the template will be used in the ceremony "Graduate Walk".
  • I have added the event to my Calendar.

Copy link
Contributor

@ShaunLWM ShaunLWM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong formatting in the markdown file - the quote value. " is not allowed. As per the requirement,

avoid using quotes(") to guarantee the format remains the same.

Copy link
Contributor

@Mohammed-Shoaib Mohammed-Shoaib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @paras1810,

Congrats on graduating! πŸŽ“ πŸŽ‰

It seems like you are pointing to an image file that doesn't exist, please point correctly in the markdown file.

Unfortunately, the checklist hasn't been marked. We cannot add your information to the yearbook without your permission. You can edit your comment and mark the task list by changing [ ] to [x]. Please refer here for more information.

Could you please make these changes? πŸ“

Thanks,
Mohammed Shoaib

---
name: Paras Jain # No longer than 18 characters
institution: Maharaja Surajmal Of Technology # no longer than 58 characters
profile_pic: paras.jpg # Relative path to the image you uploaded
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect file name, please do one of the following:

  1. Change paras.jpg to paras1810.jpg in the markdown file.
  2. Rename paras1810.jpg to paras.jpg.
    I'd suggest you make the change in the markdown file as it matches you GitHub username!

---
name: Paras Jain # No longer than 18 characters
institution: Maharaja Surajmal Of Technology # no longer than 58 characters
profile_pic: paras.jpg # Relative path to the image you uploaded
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
profile_pic: paras.jpg # Relative path to the image you uploaded
profile_pic: paras1810.jpg

Comment on lines +2 to +4
name: Paras Jain # No longer than 18 characters
institution: Maharaja Surajmal Of Technology # no longer than 58 characters
profile_pic: paras.jpg # Relative path to the image you uploaded
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
name: Paras Jain # No longer than 18 characters
institution: Maharaja Surajmal Of Technology # no longer than 58 characters
profile_pic: paras.jpg # Relative path to the image you uploaded
name: Paras Jain
institution: Maharaja Surajmal Of Technology
profile_pic: paras.jpg

name: Paras Jain # No longer than 18 characters
institution: Maharaja Surajmal Of Technology # no longer than 58 characters
profile_pic: paras.jpg # Relative path to the image you uploaded
quote: Thanks to teachers and fellow students who encouraged me to get here. I'm going to miss you all! # No longer than 100 characters
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
quote: Thanks to teachers and fellow students who encouraged me to get here. I'm going to miss you all! # No longer than 100 characters
quote: Thanks to teachers and fellow students who encouraged me to get here. I'm going to miss you all!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants