Skip to content
This repository has been archived by the owner on Jul 28, 2020. It is now read-only.

Jo added #4028

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Jo added #4028

wants to merge 4 commits into from

Conversation

devwithjp
Copy link

@devwithjp devwithjp commented May 26, 2020

Application to the Class of 2020🎓

This pull request template helps you complete an application to the Class of 2020. Use the checklist below to verify you have followed the instructions correctly.

Checklist ✅

  • I have read the instructions on the README file before submitting my application.
  • I made my submission by creating a folder on the _data folder and followed the naming convention mentioned in the instructions (<username>), added my profile picture and markdown file.
  • I have used the Markdown file template to add my information to the Year Book.
  • I have completed the form: https://airtable.com/shrmuHxu38ZariKJi
  • My application belongs to:
    • Tier 1 📖: I added myself to the Year Book.
    • Tier 2 ✏️: I wrote a post on DEV about a project I built.
    • Tier 3 ✨: I want my project to be highlighted on stream.
  • I understand that a reviewer will merge my pull request after examining it or ask for changes in case needed.
  • I understand I should not tag or add a reviewer to this Pull Request.
  • I understand the photo added to the template will be used in the ceremony "Graduate Walk".
  • I have added the event to my Calendar.

Copy link
Contributor

@abhishekds94 abhishekds94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Update the checklist and mark the Tier 1 as done

  • Profile pic name should be just the filename with an extension not the path to the file. Please update

Copy link
Contributor

@abhishekds94 abhishekds94 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! 👍

@mitulsavani
Copy link
Contributor

Looks good to me! 👍

@abhishekds94 I see the same issue with the markdown file syntax that I mentioned earlier!

Copy link
Contributor

@mitulsavani mitulsavani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Fistus

  1. Checklist complete--(Okay)
  2. Files modified--2(Not Okay)
  3. Profile picture checked--(Okay)

What needs to be resolved?

  • Your our markdown/readme file seems to have an incorrect format, please maintain the original hyphens at header and footers. You are missing --- on the top and bottom of the file.

Copy link
Contributor

@Mohammed-Shoaib Mohammed-Shoaib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Fistus,

Congrats on graduating! 🎓 🎉

Thanks for making the changes requested by @abhishekds94 and @mitulsavani. Great work you guys! ✨

Your folder name must be the same as your GitHub username. Please change the name of your folder from Jo to fistus. 📝

You can read instructions on the README file for more information.

Thanks,
Mohammed Shoaib

_data/Jo/Jo.md Outdated Show resolved Hide resolved
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants