Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more browsers to the overview #16

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add more browsers to the overview #16

wants to merge 2 commits into from

Conversation

lefta
Copy link

@lefta lefta commented Jun 3, 2018

This PR adds almost all browsers to the overview (except NodeJS, this is useless for CSS). It relies on the up to date dataset from #15, some browsers are not in the current dataset.

By the way, the new dataset have a browsers.xxx.name field, so I made use of it to get browser names automatically. This avoids the mess of having to maintain it manually. Please let me know if you don't agree with it, I will drop this change 馃槂

Note that some of the new browsers are not fully documented in the new dataset. I expect MDN to fill it over the time, but for now it wrongly reports a lot of features as unsupported. Maybe should we put a warning in the readme about that ?

EDIT: BTW, this breaks the "all columns of the same width" stuff as the overview is ways larger now. This is just a visual artifact so I did not manage to fix it for now, I don't even know what would be the best way. ( Horizontal scrolling ? Using icons like on MDN to lower the columns width ? Or anything else ? )

@eduardoboucas
Copy link
Owner

This looks great, thank you!

Regarding the column width, I don't know what the best solution is. Do you think we should figure that out first before merging this PR, or not necessarily?

Thanks.

@lefta
Copy link
Author

lefta commented Jun 5, 2018

You're welcome ;)

I don't think the column width is a problem, this is more a small visual artifact rather than a real anoyance. At least, it did not break the UX for me. IMO, you can merge this PR as is. Once done, I will open a ticket to see with you what the best way to handle it would be (which is very subjective BTW...).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants