Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update it #386

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Update it #386

wants to merge 4 commits into from

Conversation

ETCHDEV
Copy link
Contributor

@ETCHDEV ETCHDEV commented Apr 24, 2024

Description

[Description of the changes you are submitting]

Checklist

  • Have you tested the change you are submitting?
  • Is the commits history nice and clean?

@gus33000
Copy link
Contributor

Edk2 main branch is known to introduce breaking changes often breaking the build process. As a result if you drop the last commit here you may one day make builds fail due to an update on their end. I think it would be better to set the last known good commit sha1 instead of removing it all together. Even if you can rely on git submodule functionality it at least documents nicely the commit intended to work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants