Remove non-english locales from Moment.js #582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Our bundle size has grown pretty large, and a significant chunk of it is localization data for Moment.js. Since we only show the site in English, that's a bit of a waste. This removes non-English locales from our built bundle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our bundle size has grown pretty large, and a significant chunk of it used to be localization data for Moment.js. Since we only show the site in English, that's a bit of a waste. This removes non-English locales from our built bundle.
NOTE: Technically the extra locales aren’t currently being included and this PR makes no difference to the bundle size, but only because of a bug with Moment.js (see moment/moment#5489). The latest version of Moment fixes the issue, but pumps our size back up (see #556). This should prevent that.
This is a replacement for part of #490. Another part (adding bundle analyzer) I’ll do separately to keep things clean. And the last part (automatically checking for size increases) is already done in #579.