Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Podman engine #160

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Add Podman engine #160

wants to merge 5 commits into from

Conversation

babykart
Copy link
Contributor

PR related to #159

Copy link
Owner

@edannenberg edannenberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for some minor stuff. 👍 No worries if you can't be bothered.

engine/podman.sh Outdated Show resolved Hide resolved
engine/docker.sh Outdated Show resolved Hide resolved
edannenberg pushed a commit that referenced this pull request May 13, 2019
edannenberg added a commit that referenced this pull request May 13, 2019
@edannenberg
Copy link
Owner

Squashed and merged. Thanks again! I'll leave this open until I get to update the docs for this. The 9999 ebuild already has a podman use flag now.

@babykart
Copy link
Contributor Author

A last commit, sorry.
After reviewing in details the documentation of podman, commit and build have a default argument --format=oci.
I introduced a new variable/parameter (strictly like as build command) on commit phase, it's set as default --format=docker.

edannenberg pushed a commit that referenced this pull request May 14, 2019
Also adds an option to configure docker commit args.
@babykart
Copy link
Contributor Author

@edannenberg

With the last update on master, docker/podman commit fail with empty {DOCKER,PODMAN}_COMMIT_OPTS:

"docker commit" requires at least 1 and at most 2 arguments.

To fix it:

diff --git a/engine/docker.sh b/engine/docker.sh
index e81832c..6765493 100644
--- a/engine/docker.sh
+++ b/engine/docker.sh
@@ -229,7 +229,7 @@ function build_image() {
         _container_mount_portage='false'

         _status_msg="commit ${run_id} as image ${_current_namespace}/${builder_commit_id}:${IMAGE_TAG}"
-        pwrap 'nolog' "${DOCKER}" commit "${DOCKER_COMMIT_OPTS}" "${run_id}" "${_current_namespace}/${builder_commit_id}:${IMAGE_TAG}" \
+        pwrap 'nolog' "${DOCKER}" commit ${DOCKER_COMMIT_OPTS} "${run_id}" "${_current_namespace}/${builder_commit_id}:${IMAGE_TAG}" \
             || die "${_status_msg}"

edannenberg added a commit that referenced this pull request May 14, 2019
@edannenberg
Copy link
Owner

My bad, somewhat blindly fixed the shellcheck error for that. Fixed.

edannenberg pushed a commit that referenced this pull request Apr 14, 2020
>=libpod-1.8.0 now supports the -f argument for image prune
berney added a commit to berney/kubler that referenced this pull request Jul 8, 2021
edannenberg pushed a commit that referenced this pull request Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants