Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MOB-2541] Fix missing locators #683

Merged
merged 3 commits into from
May 21, 2024
Merged

[MOB-2541] Fix missing locators #683

merged 3 commits into from
May 21, 2024

Conversation

d4r1091
Copy link
Member

@d4r1091 d4r1091 commented May 16, 2024 •
edited by jira bot

MOB-2541

Context

Some issues with the accessibility identifiers were raised by the QA team.
The goal is not only to fix them but to improve the robustness of those identifiers.

Approach

  • Verify the missing identifiers and add them, after catching up with @mujjazi

Other

Before merging

Checklist

  • I performed some relevant testing on a real device and/or simulator

@d4r1091 d4r1091 requested a review from a team May 16, 2024 15:08
@d4r1091 d4r1091 changed the title Mob 2541 fix missing locators [MOB-2541] Fix missing locators May 16, 2024
lucaschifino
lucaschifino approved these changes May 21, 2024
View reviewed changes
Copy link

@lucaschifino lucaschifino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

♿ 🤖

@d4r1091 d4r1091 merged commit 460f42c into MOB-2012_firefox_120_upgrade May 21, 2024
@d4r1091 d4r1091 deleted the MOB-2541_fix_missing_locators branch May 21, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lucaschifino lucaschifino lucaschifino approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@d4r1091 @lucaschifino