Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Case Insensitive Materials Redirects #36

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

camriddell
Copy link
Collaborator

Addresses the case-sensitivity in the materials urls via the github-pages supported jekyll-redirect-from plugin.

Longer term solutions will require a larger rewrite of the site infrastructure (incorporating a custom jekyll build and a new github action, or using our own web server). In the meantime, this will solve most case sensitivity issues for the materials pages.

@camriddell
Copy link
Collaborator Author

@DrDrij since I made changes to the yaml frontmatter to add in the redirects_from values, do you know if these will be overwritten by the copycat github action?

@DrDrij
Copy link
Member

DrDrij commented Jan 27, 2023

@DrDrij since I made changes to the yaml frontmatter to add in the redirects_from values, do you know if these will be overwritten by the copycat github action?

@camriddell Correct, if the github action notices that a Markdown file has been updated it will sync it across to the website repository. If the most up to date version now exists on this website repo, then perhaps we should copy these Markdown files into their respective repositories?

eg. copy this: https://raw.githubusercontent.com/econ-ark/econ-ark.org/d4f024f7fe86d26f44a49141d44a45c56a86e69e/_materials/Aiyagari.md

into: https://raw.githubusercontent.com/econ-ark/REMARK/master/REMARKs/Aiyagari.md

@llorracc
Copy link
Contributor

@camriddell @DrDrij

I see that this has conflicts, so presumably it is not ready to merge. Should it have a [WIP] (work in progress) label until ready to merge? And, @DrDrij, I presume you have the permissions necessary to merge it when it is no longer WIP?
If so, please go ahead and merge without consulting me when it is working.

@llorracc
Copy link
Contributor

@camriddell: Pinging you on this. I'd love to get case insensitivity fixed. Let me know when it's ready to merge!

@camriddell
Copy link
Collaborator Author

This PR was more of a one time patch, in order to consider future updates to metadata, we'll need a separate build step- meaning we'll need to utilize an orphan branch to publish from (typically gh-pages).

I'll need to converse with @DrDrij to make sure I don't interfere with anything else, but the envisioned change would be:

  1. copycat pulls the markdown files
  2. case insensitive script runs, adding in the redirects programmatically
  3. when intermediate step(s) are complete, push contents to gh-pages branch to trigger build

The reason for relying on an orphan branch like gh-pages is that we don't want to trigger builds during those intermediate steps.

@alanlujan91
Copy link
Member

@camriddell is this still active?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants