Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add --fastStartup flag #25

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add --fastStartup flag #25

wants to merge 1 commit into from

Conversation

sgraband
Copy link

@sgraband sgraband commented Jan 10, 2022

What it does

When flag is enabled the plugin deployment will be delayed until a frontend is connected.
This way the deployment of the plugins cannot slow down the fronend loading time.
When the flag is not enabled the performance is not affected.

Contributed on behalf of STMicroelectronics

Signed-off-by: Simon Graband sgraband@eclipsesource.com

How to test

Review checklist

Reminder for reviewers

@sgraband sgraband changed the title Deploy performance Add --fastStartup flag Jan 10, 2022
@sdirix sdirix changed the base branch from master to 0.6.1 January 10, 2022 11:42
@sdirix sdirix changed the base branch from 0.6.1 to master January 10, 2022 11:42
Copy link
Member

@sdirix sdirix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit, Changelog and Headers need to have the correct copyright

Please also add the measurements and how they were obtained to the PR description

Also mention that behavior does not change for people not using the flag

packages/core/src/node/backend-application.ts Outdated Show resolved Hide resolved
packages/core/src/node/connection-notifier.ts Outdated Show resolved Hide resolved
When flag is enabled the plugin deployment will be delayed until a frontend is connected.
This way the deployment of the plugins cannot slow down the fronend loading time.
When the flag is not enabled the performance is not affected.

Contributed on behalf of STMicroelectronics

Signed-off-by: Simon Graband <sgraband@eclipsesource.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants