Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tycho 4 #2955

Merged
merged 8 commits into from Mar 7, 2024
Merged

Tycho 4 #2955

merged 8 commits into from Mar 7, 2024

Conversation

LorenzoBettini
Copy link
Contributor

Closes #2694

I've also taken the chance to update our Maven wrapper to 3.9.6

Note that I had to do a few adjustments concerning tests that must be executed with maven-surefire, since as documented, Tycho 4 does not automatically enable maven-surefire anymore.

@LorenzoBettini LorenzoBettini added this to the Release_2.35 milestone Mar 7, 2024
@cdietrich
Copy link
Member

can you also request/pr against xtext-reference-projects?
should dm example be updated too?

@LorenzoBettini
Copy link
Contributor Author

can you also request/pr against xtext-reference-projects? should dm example be updated too?

The Domainmodel example in this repository has already been updated.

Concerning reference projects what should I do in particular?

@cdietrich
Copy link
Member

cdietrich commented Mar 7, 2024

you import the project.
run the launcher.
see the diffs
update the domain model manually.

check github workflows build.yml

@LorenzoBettini
Copy link
Contributor Author

OK.
Can I do it independently from this PR, or should this be merged first?

@cdietrich
Copy link
Member

ususally you do it the other way round
the referrence projects show that your changes to the wizard / dm example work

@LorenzoBettini
Copy link
Contributor Author

@cdietrich I created the PR for reference projects, hoping I got it right

@LorenzoBettini
Copy link
Contributor Author

@cdietrich now that xtext/xtext-reference-projects#410 has been merged, can I merge this as well?

@LorenzoBettini LorenzoBettini merged commit 03146da into main Mar 7, 2024
10 checks passed
@LorenzoBettini LorenzoBettini deleted the lb_tycho4 branch March 7, 2024 13:24
@LorenzoBettini
Copy link
Contributor Author

@cdietrich I'll also remove your old branch

@cdietrich
Copy link
Member

yes. can you please also rebase the 50 one

@LorenzoBettini
Copy link
Contributor Author

sure!

@LorenzoBettini
Copy link
Contributor Author

@cdietrich I rebased your branch and solved the conflicts, please have a look

@LorenzoBettini
Copy link
Contributor Author

On Jenkins it fails with

14:52:51  [INFO] Scanning for projects...
14:52:51  [WARNING] The POM for org.eclipse.tycho:tycho-maven-plugin:jar:5.0.0-SNAPSHOT is missing, no dependency information available
14:52:52  [ERROR] [ERROR] Some problems were encountered while processing the POMs:
14:52:52  [ERROR] Unresolveable build extension: Plugin org.eclipse.tycho:tycho-maven-plugin:5.0.0-SNAPSHOT or one of its dependencies could not be resolved: The following artifacts could not be resolved: org.eclipse.tycho:tycho-maven-plugin:jar:5.0.0-SNAPSHOT (absent): Could not find artifact org.eclipse.tycho:tycho-maven-plugin:jar:5.0.0-SNAPSHOT @ 

I don't understand why... on GitHub Actions it's building...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update to Tycho 4.0
2 participants