initialize local variables before use #693
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes error: 'ctrl_reg2_data' may be used uninitialized in this function [-Werror=maybe-uninitialized] Signed-off-by: Khem Raj <raj.khem@gmail.com>
Mani-Sadhasivam
requested changes
Jan 2, 2020
clang also introduced this warning now Signed-off-by: Khem Raj <raj.khem@gmail.com>
|
Hi @kraj, these changes are good but you would need to sign the ECA for us to be able to merge this. You can find the details on how to do so here: https://www.eclipse.org/legal/ECA.php |
I have tried to install it, please recheck, |
|
@kraj, you shouldn't have to install anything. Simply fill and submit the ECA Form on the eclipse.org website using the same e-mail from your sign-off. We can then refresh this PR and the eclipse ECA check will pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes
error: 'ctrl_reg2_data' may be used uninitialized in this function [-Werror=maybe-uninitialized]
Signed-off-by: Khem Raj raj.khem@gmail.com