Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option to display TextMate token info in hover #752

Merged
merged 1 commit into from
May 17, 2024

Conversation

sebthom
Copy link
Member

@sebthom sebthom commented May 16, 2024

This PR adds the ability to show the type and scopes of TextMate tokens in a hover which is useful when developing TM themes and needing to style specific elements.

image
image

@angelozerr
Copy link
Contributor

angelozerr commented May 16, 2024

It is a fantastic feature! Please note that vscode provides this features too https://code.visualstudio.com/api/language-extensions/syntax-highlight-guide#textmate-tokens-and-scopes andit display another relevant information

image

And vscode manage this popup with the cursor, if you change the cursor the popup is refreshed,I think it is better than hover but I don't know if it is easy to do that in Eclipse IDE.

@sebthom
Copy link
Member Author

sebthom commented May 16, 2024

@angelozerr We currently don't have all this information available. However, I added a second commit that extends the hover like this:

image

@angelozerr
Copy link
Contributor

Thanks @sebthom for your improvement.

I suggest that you write a doc about this great feature

@sebthom sebthom changed the title feat: add option to enable displaying TM scope name in hover feat: add option to display TextMate token info in hover May 17, 2024
@sebthom sebthom merged commit afe66c7 into eclipse:main May 17, 2024
18 checks passed
@sebthom sebthom deleted the hover branch May 17, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants