Fix resource leak issue - 372 #383
Conversation
|
@eselmeister please check my changes for #372. |
|
BarChartExampleModified.txt |
|
@raghucssit Thanks for your PR. Please extend the year (copyright header) in the modified files. If it was was e.g. I'm on a business trip today. I'll review your changes tomorrow. |
|
@raghucssit The change looks principally ok, but you need to address the above marked license header issue. |
Scenario - If we have multiple level of parents for chart widget and If we dispose bottom most(top most is chart) widget by invoking dispose chart widget get disposed without calling chart.dispose(). Any subsequent call to dispose never calls dispose for it's children. So checking if chart disposed in the dispose method never give an opportunity to children dispose in the above Scenario. I have added chart disposed safety check at Title because this was causing the issue eclipse#289. Fixes eclipse#372
raghucssit
force-pushed
the
fix-res-leak-372
branch
from
56316f3
to
452e1f4
Compare
Fixed. |
|
@eselmeister Can you please tell me what is the next release plan for swtchart ? |
Scenario - If we have multiple level of parents for chart widget and If we dispose bottom most(top most is chart) widget by invoking dispose chart widget get disposed without calling chart.dispose(). Any subsequent call to dispose never calls dispose for it's children. So checking if chart disposed in the dispose method never give an opportunity to children dispose in the above Scenario. I have added chart disposed safety check at Title because this was causing the issue #289.
Fixes #372