Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 580941: Fix NPE in AutInstall when launching from sources. A second protottype. #27

Merged
merged 14 commits into from Apr 4, 2024

Conversation

basilevs
Copy link
Contributor

No description provided.

@basilevs
Copy link
Contributor Author

AUT fails with:

!ENTRY org.eclipse.osgi 4 0 2023-12-13 09:53:24.421
!MESSAGE Application error
!STACK 1
java.lang.RuntimeException: No application id has been found.
	at org.eclipse.equinox.internal.app.EclipseAppContainer.startDefaultApp(EclipseAppContainer.java:246)
	at org.eclipse.equinox.internal.app.MainApplicationLauncher.run(MainApplicationLauncher.java:33)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:136)
	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:402)
	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:255)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:659)
	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:596)
	at org.eclipse.equinox.launcher.Main.run(Main.java:1467)
	at org.eclipse.equinox.launcher.Main.main(Main.java:1440)

This either indicates a bad config or missing workspace plugin injection. Further investigation is required. This could be a time for integration tests.

@basilevs
Copy link
Contributor Author

basilevs commented Mar 19, 2024

I don't know what I did, but my tests are passing now on RCPTT installed in Eclipse for Committer 2023-06.
Update: the regression only happens on later targets, which we did not support yet.

@basilevs
Copy link
Contributor Author

basilevs commented Mar 22, 2024

Tests fail to start due to changes from platform_2024-03

@basilevs basilevs added this to the 2.5.5 milestone Mar 27, 2024
@basilevs basilevs merged commit ec9827d into master Apr 4, 2024
4 of 5 checks passed
@basilevs basilevs deleted the bug/580941/npe2 branch April 4, 2024 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant