Updated to Eclipse 2023-06 #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basilevs
requested changes
Jun 28, 2023
rcp/org.eclipse.rcptt.search/src/org/eclipse/rcptt/search/Q7SearchResultPage.java
Outdated
Show resolved
Hide resolved
....impl/src/org/eclipse/rcptt/ecl/data/apache/poi/impl/internal/commands/ExcelFileService.java
Outdated
Show resolved
Hide resolved
|
I've fixed CI to support external PRs: https://ci.eclipse.org/rcptt/job/Pull_requests/job/PR-21/2/ |
HannesWell
reviewed
Aug 31, 2023
|
This still fails to run an Eclipse RCP application with framework version 2023-06 at runtime: Log |
Weaving errors hint (weakly) at AspectJ problem. It may need an update |
|
The PR build fails due to use of Java 11 in the devenv image. I'll try to update to Java 17 this weekend, but that may be hard to do with the old Ubuntu image in use. |
Confirmed. A rebase fixes it! |
Mailaender
force-pushed
the
2023-06
branch
3 times, most recently
from
315b5c4
to
55b3362
Compare
Merged
|
Java on CI is updated. |
|
Build fails because Update /org.eclipse.rcptt.tesla.swt/META-INF/MANIFEST.MF replacing with As this is a runtime component, compatible with older Eclipses, we can't use latest Java there. |
A dependency |
|
Not all plugins required Java bump. I'm torn on this - on one hand, no plug-ins will be used in Java 1.6 anymore. On the other hand - reader no longer knows which plug-in really requires Java 1.8. |
|
I thought |
basilevs
reviewed
Dec 4, 2023
Tycho bug? |
Mailaender
force-pushed
the
2023-06
branch
5 times, most recently
from
74eaffa
to
b7880b6
Compare
The integration test fails because RCPTT IDE under test is missing a dependency - plugin biz.aQute.bndlib is missing from AUT's target platform. I've downloaded the product and it has the plugin. I've created AUT and it starts fine. Not sure what's going on. Restarting the build. |
Does not help. The error persists. A deeper investigation is needed. |
|
According to the build error message, org.eclipse.pde.core requires bundle biz.aQute.bndlib older than 5: Notably RCPTT Runner reports same error. AUT started from IDE has biz.aQute.bndlib_6.4.0.202211291949.jar in rcptt_workspace/.metadata/.plugins/org.eclipse.pde.core/org.eclipse.rcptt.platform.product/org.eclipse.equinox.simpleconfigurator/bundles.info thise version exports the package of required version: aQute.bnd.build 4.4.0. No biz.* plugins are present in the RCPTT update site, but org.eclipse.pde.core is there. |
basilevs
added a commit
that referenced
this pull request
Mar 13, 2024
basilevs
added a commit
that referenced
this pull request
Mar 13, 2024
|
Thanks for looking into it. |
|
When installing RCPTT IDE from the latest PR build and launching itself as AUT, a following error happens: Bundled product works fine. |
|
I tested https://ci.eclipse.org/rcptt/job/Pull_requests/job/PR-21/22/artifact/repository/full/target/products/ with @OpenChrom and it works just fine. |
|
When installing RCPTT from update site it injects older AspectJ: A version from update site uses: Hypothesis: this is another case of Tycho reproducible version qualifiers being confused by complex Git graph. Solution is to touch any file in dependencies/bundles/org.eclipse.rcptt.updates.aspectj.e44x Update: TODO: remember why pom.xml is excluded. |
basilevs
added a commit
that referenced
this pull request
Mar 14, 2024
The error: [INFO] !ENTRY org.eclipse.core.jobs 4 2 2024-03-14 12:01:21.230 [INFO] !MESSAGE An internal error occurred during: "Debug Event Dispatch". [INFO] !STACK 0 [INFO] java.lang.OutOfMemoryError: Java heap space [INFO] at java.base/java.util.zip.ZipFile$Source.initCEN(ZipFile.java:1476) [INFO] at java.base/java.util.zip.ZipFile$Source.<init>(ZipFile.java:1297) [INFO] at java.base/java.util.zip.ZipFile$Source.get(ZipFile.java:1259) [INFO] at java.base/java.util.zip.ZipFile$CleanableResource.<init>(ZipFile.java:707) [INFO] at java.base/java.util.zip.ZipFile.<init>(ZipFile.java:241) [INFO] at java.base/java.util.zip.ZipFile.<init>(ZipFile.java:172) [INFO] at org.eclipse.pde.internal.core.util.ManifestUtils.loadManifest(ManifestUtils.java:108) [INFO] at org.eclipse.pde.internal.core.MinimalState.addBundle(MinimalState.java:179) [INFO] at org.eclipse.pde.internal.core.PDEState.createNewTargetState(PDEState.java:97) [INFO] at org.eclipse.pde.internal.core.PDEState.<init>(PDEState.java:64) [INFO] at org.eclipse.rcptt.launching.ext.Q7ExternalLaunchDelegate.getModels(Q7ExternalLaunchDelegate.java:889) [INFO] at org.eclipse.rcptt.launching.ext.Q7ExternalLaunchDelegate.access$0(Q7ExternalLaunchDelegate.java:888) [INFO] at org.eclipse.rcptt.launching.ext.Q7ExternalLaunchDelegate$BundlesToLaunchCollector.addPluginBundle(Q7ExternalLaunchDelegate.java:690) [INFO] at org.eclipse.rcptt.launching.ext.Q7ExternalLaunchDelegate$BundlesToLaunchCollector.access$1(Q7ExternalLaunchDelegate.java:689) [INFO] at org.eclipse.rcptt.launching.ext.Q7ExternalLaunchDelegate.collectBundles(Q7ExternalLaunchDelegate.java:824) [INFO] at org.eclipse.rcptt.launching.ext.Q7ExternalLaunchDelegate.collectBundlesCheck(Q7ExternalLaunchDelegate.java:800) [INFO] at org.eclipse.rcptt.launching.ext.Q7ExternalLaunchDelegate.preLaunchCheck(Q7ExternalLaunchDelegate.java:635) [INFO] at org.eclipse.pde.launching.AbstractPDELaunchConfiguration.launch(AbstractPDELaunchConfiguration.java:140) [INFO] at org.eclipse.rcptt.launching.ext.Q7ExternalLaunchDelegate.launch(Q7ExternalLaunchDelegate.java:127) [INFO] at org.eclipse.debug.internal.core.LaunchConfiguration.launch(LaunchConfiguration.java:806) [INFO] at org.eclipse.debug.internal.core.LaunchConfiguration.launch(LaunchConfiguration.java:717) [INFO] at org.eclipse.debug.internal.core.LaunchConfiguration.launch(LaunchConfiguration.java:712) [INFO] at org.eclipse.rcptt.internal.launching.aut.BaseAutLaunch.restart(BaseAutLaunch.java:454) [INFO] at org.eclipse.rcptt.internal.launching.aut.BaseAutLaunch.terminateProcess(BaseAutLaunch.java:518) [INFO] at org.eclipse.rcptt.internal.launching.aut.BaseAutManager.handleDebugEvents(BaseAutManager.java:248) [INFO] at org.eclipse.debug.core.DebugPlugin$EventNotifier.run(DebugPlugin.java:1226) [INFO] at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:45) [INFO] at org.eclipse.debug.core.DebugPlugin$EventNotifier.dispatch(DebugPlugin.java:1260) [INFO] at org.eclipse.debug.core.DebugPlugin$EventDispatchJob.run(DebugPlugin.java:492) [INFO] at org.eclipse.core.internal.jobs.Worker.run(Worker.java:63)
New Aspectj and --add-opens argument are required
basilevs
approved these changes
Mar 20, 2024
|
We stabilized this to the best of our abilities given time constraints. I'm merging this. |
|
I've started work on 2024-03 (4.31) in https://github.com/eclipse/org.eclipse.rcptt/tree/platform_2024-03 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://projects.eclipse.org/releases/2023-06 has been released last week with some breaking changes.