feat: com aux able to receive timestamps #466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #466 +/- ##
=======================================
Coverage 98.14% 98.14%
=======================================
Files 84 84
Lines 6747 6750 +3
=======================================
+ Hits 6622 6625 +3
Misses 125 125 ☔ View full report in Codecov by Sentry. |
sebastianpfischer
approved these changes
Mar 25, 2024
sebclrsn
reviewed
Mar 25, 2024
|
|
||
| # stay with the old return type to not making a breaking change | ||
| if remote_id is not None: | ||
| if remote_id and timestamp: | ||
| return (msg, remote_id, timestamp) |
There was a problem hiding this comment.
That's still a breaking change, or am I missing something?
There was a problem hiding this comment.
Please add an additional keyword argument receive_timestamp: bool = False so that no breaking change occurs
sebclrsn
reviewed
Mar 27, 2024
TedRio
force-pushed
the
feature/com_aux_receive_msg_with_timestamp
branch
from
8e2008b
to
b34ecec
Compare
sebclrsn
reviewed
Mar 27, 2024
| @@ -136,6 +136,7 @@ def receive_message( | |||
| self, | |||
| blocking: bool = True, | |||
| timeout_in_s: float = None, | |||
| receive_timestamp: bool = False, | |||
| ) -> Optional[bytes]: | |||
There was a problem hiding this comment.
Suggested change
| ) -> Optional[bytes]: | |
| ) -> Optional[bytes | Tuple[bytes, int] | Tuple[bytes, int, float]]: |
sebclrsn
reviewed
Mar 27, 2024
| @@ -136,6 +136,7 @@ def receive_message( | |||
| self, | |||
| blocking: bool = True, | |||
| timeout_in_s: float = None, | |||
| receive_timestamp: bool = False, | |||
There was a problem hiding this comment.
Parameter docstring is missing 🙈
There was a problem hiding this comment.
Ouuups, sorry I was trying to be quick so it can be merge before 0.28.0 🚑
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.