feat: add start stop can trace #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #465 +/- ##
==========================================
+ Coverage 98.12% 98.14% +0.02%
==========================================
Files 84 84
Lines 6710 6747 +37
==========================================
+ Hits 6584 6622 +38
+ Misses 126 125 -1 ☔ View full report in Codecov by Sentry. |
sebclrsn
reviewed
Mar 21, 2024
sebclrsn
approved these changes
Mar 21, 2024
sebastianpfischer
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the possibility to stop and start pcan trace and to specify name of the logfile wanted.
Since the user can specify a new path when he starts the pcan trace he can choose a different repository, I added a dictionary that has for key the directory path and as value a list of all the file_name for this repository to be able to rename all of them or to merge them depending on the logic wanted.