Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tag to unit tests in Haiku and Wordle kata #339

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add tag to unit tests in Haiku and Wordle kata #339

wants to merge 1 commit into from

Conversation

ivalkshfoeif
Copy link

@ivalkshfoeif ivalkshfoeif commented Sep 22, 2023 •
edited

fix for issue #283

@prathasirisha
Copy link
Contributor

Hi @ivalkshfoeif - can you update your PR , you can do this by -

git pull --rebase upstream master
git push --force-with-lease

@ivalkshfoeif
Copy link
Author

Hi @prathasirisha, I have updated my PR, please let me know if there is anything else I need to do.

prathasirisha
prathasirisha reviewed Sep 26, 2023
View reviewed changes
wordle-kata/src/test/java/org/eclipse/collections/wordlekata/WordleJDKTest.java Outdated
import org.junit.jupiter.api.Test;

ß
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is an extra character here - could you please remove it.

@prathasirisha
Copy link
Contributor

After addressing the comment above, could you squash all your commits to 1 commit?

@ivalkshfoeif
Copy link
Author

ivalkshfoeif commented Sep 26, 2023 •
edited

After addressing the comment above, could you squash all your commits to 1 commit?

Sure, @prathasirisha , I have squashed them

@ivalkshfoeif ivalkshfoeif reopened this Sep 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prathasirisha prathasirisha prathasirisha left review comments

@rachanavishwanath rachanavishwanath rachanavishwanath approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ivalkshfoeif @prathasirisha @rachanavishwanath