Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check build with different sets of features #940

Open
milyin opened this issue Apr 16, 2024 · 0 comments
Open

check build with different sets of features #940

milyin opened this issue Apr 16, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@milyin
Copy link
Contributor

milyin commented Apr 16, 2024

Build check with some feature combinations fails at this moment. For example this command fails:

> cargo check -p zenoh --tests
...
error[E0425]: cannot find function `init` in crate `zenoh`
   --> zenoh/tests/session.rs:230:25
    |
230 |     let peer01 = zenoh::init(r1.clone()).res_async().await.unwrap();
    |                         ^^^^ not found in `zenoh`
    |

but this works ok:

cargo check --tests

This happens because some features (unstable in this particular case) are required by dependent crates and therefore build of base crates passes ok. But by default, when feature is not explicitly specified, build fails. This command works ok:

cargo check -p zenoh --tests --features unstable 

It's necessary to systematically ensure that build works with at least most of feature combinations and do it for each crate separately

@milyin milyin added the bug Something isn't working label Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: No status
Development

No branches or pull requests

1 participant