Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Liveliness implementation #865

Open
wants to merge 96 commits into
base: dev/1.0.0
Choose a base branch
from
Open

Refactor Liveliness implementation #865

wants to merge 96 commits into from

Conversation

fuzzypixelz
Copy link
Member

Resolves #864.

@eclipse-zenoh-bot
Copy link

@fuzzypixelz If this pull request contains a bugfix or a new feature, then please consider using Closes #ISSUE-NUMBER syntax to link it to an issue.

@fuzzypixelz fuzzypixelz marked this pull request as draft March 26, 2024 11:01
@fuzzypixelz fuzzypixelz changed the title Refactor/liveliness delaration Refactor Liveliness implementation Mar 26, 2024
@eclipse-zenoh-bot
Copy link

@fuzzypixelz If this pull request contains a bugfix or a new feature, then please consider using Closes #ISSUE-NUMBER syntax to link it to an issue.

@fuzzypixelz fuzzypixelz force-pushed the refactor/liveliness-delaration branch from dc9ec91 to 5b2ebbb Compare March 26, 2024 11:25
@fuzzypixelz fuzzypixelz changed the base branch from protocol_changes to client-interests March 26, 2024 11:27
@eclipse-zenoh-bot
Copy link

@fuzzypixelz If this pull request contains a bugfix or a new feature, then please consider using Closes #ISSUE-NUMBER syntax to link it to an issue.

@OlivierHecart OlivierHecart linked an issue Mar 26, 2024 that may be closed by this pull request
Protocol changes: Refactor Liveliness implementation #864
Open
@OlivierHecart OlivierHecart self-requested a review March 26, 2024 11:49
@fuzzypixelz fuzzypixelz force-pushed the refactor/liveliness-delaration branch from fd7c307 to 8961ba3 Compare March 26, 2024 14:41
@OlivierHecart
Add client writer-side filtering (eclipse-zenoh#863)
cede672 
* Add client writer-side filtering

* Reimplement liveliness with interests

* Fix writer-side filtering before receiving FinalInterest
@OlivierHecart OlivierHecart deleted the branch eclipse-zenoh:dev/1.0.0 March 27, 2024 09:19
@OlivierHecart OlivierHecart reopened this Mar 27, 2024
@OlivierHecart OlivierHecart changed the base branch from client-interests to interests March 27, 2024 11:42
@fuzzypixelz fuzzypixelz force-pushed the refactor/liveliness-delaration branch from 8961ba3 to a3a9c7e Compare March 27, 2024 14:37
@fuzzypixelz
Copy link
Member Author

fuzzypixelz commented Mar 28, 2024 •
edited

What works now:

  1. Liveliness declaration, w/o the interest protocol, in brokered scenarios
  2. Liveliness get, w/o the interest protocol, in brokered scenarios

I disabled unused_variables and dead_code lints to unblock the CI.

@fuzzypixelz fuzzypixelz force-pushed the refactor/liveliness-delaration branch from 2e0afa9 to 3fcdb2c Compare March 28, 2024 17:05
@fuzzypixelz fuzzypixelz force-pushed the refactor/liveliness-delaration branch from ed4e400 to cde8da2 Compare May 14, 2024 07:40
@fuzzypixelz
Copy link
Member Author

fuzzypixelz commented May 14, 2024 •
edited

Update:

  1. The .liveliness().get(..) API now sends interest declaration messages instead of requests.
  2. Incoming token declaration messages are sent to liveliness query callbacks.

@fuzzypixelz fuzzypixelz self-assigned this May 17, 2024
@OlivierHecart OlivierHecart changed the base branch from interests to dev/1.0.0 May 22, 2024 13:16
@fuzzypixelz
fix: Remove zenoh::net::routing::PREFIX_LIVELINESS
5e6428a 
The key assumption here is that no key expression
can start with '@/liveliness' anymore.
@fuzzypixelz
fix: Set ext_qos to QoSType::DEFAULT when for liveliness queries
a4e9609
@fuzzypixelz
fix: Don't immediatly reply with DeclareFinal to token interest
3c9e90b
@fuzzypixelz
fix: Send DeclareToken w/ interest id for InterestMode::Current
81f00fb
@fuzzypixelz
fix: Send DeclareFinal in response to Current token interest
6d7be6e
@fuzzypixelz
fix: Set ext_qos: QoSType::DEFAULT in routing interest declaration
bb03300
@fuzzypixelz
fix: Share ownership of TokenQuery b/w destination faces
d193991
@fuzzypixelz
Merge remote-tracking branch 'upstream/dev/1.0.0' into refactor/livel…
71839c1 
…iness-delaration
@fuzzypixelz
fix: Remove unused code
f7ba73a
@fuzzypixelz
fix: Rustfmt errors with CI config
51c4e0f
@fuzzypixelz
test: Liveliness clique/brokered and subscriber/query scenarios
8f1bba3
@fuzzypixelz
fix: Don't declare tokens with interest ids for CurrentFuture
42c62d1
@fuzzypixelz
fix: Incorrect wire expr for liveliness undeclaration callbacks
7bea9ce
@fuzzypixelz
fix: Support liveliness queries to linkstate/p2p peers
85c7410
@fuzzypixelz fuzzypixelz added enhancement Existing things could work better internal Changes not included in the changelog labels May 24, 2024
@fuzzypixelz fuzzypixelz marked this pull request as ready for review May 24, 2024 14:58
@fuzzypixelz fuzzypixelz force-pushed the refactor/liveliness-delaration branch from 9ddc253 to 998592d Compare May 24, 2024 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OlivierHecart OlivierHecart Awaiting requested review from OlivierHecart

Assignees

@fuzzypixelz fuzzypixelz

Labels
enhancement Existing things could work better internal Changes not included in the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Protocol changes: Refactor Liveliness implementation
4 participants
@fuzzypixelz @eclipse-zenoh-bot @OlivierHecart @Mallets