Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compression doesn't work on pub/sub example #1028

Closed
esemeniuc opened this issue May 14, 2024 · 4 comments
Closed

Compression doesn't work on pub/sub example #1028

esemeniuc opened this issue May 14, 2024 · 4 comments
Labels
bug Something isn't working

Comments

@esemeniuc
Copy link

Describe the bug

When adding the following to z_pub.rs and z_sub.rs, no packets are received.

    config
        .transport
        .unicast
        .set_compression(CompressionUnicastConf::new(true).unwrap())
        .unwrap();

See https://github.com/eclipse-zenoh/zenoh/compare/0.11.0-rc.2...jito-labs:zenoh:eric/compress?expand=1

To reproduce

  1. Start publisher
  2. Start subscriber
  3. No packets are received

System info

Arch Linux 6.6.28-1-lts
Default rust from toolchain file

@esemeniuc esemeniuc added the bug Something isn't working label May 14, 2024
@YuanYuYuan
Copy link
Contributor

Hi @esemeniuc, I applied your diff but couldn't reproduce it. Can you recheck?

./target/debug/examples/z_pub
Opening session...
2024-05-15T08:20:11.046384Z  INFO main ThreadId(01) zenoh::net::runtime: Using ZID: dd656f8cd2695bfae7d46eeac16dea7d
2024-05-15T08:20:11.195017Z  INFO main ThreadId(01) zenoh::net::runtime::orchestrator: Zenoh can be reached at: tcp/192.168.1.140:41511
2024-05-15T08:20:11.195194Z  INFO main ThreadId(01) zenoh::net::runtime::orchestrator: zenohd listening scout messages on 224.0.0.224:7446
Declaring Publisher on 'demo/example/zenoh-rs-pub'...
Press CTRL-C to quit...
Putting Data ('demo/example/zenoh-rs-pub': '[   0] Pub from Rust!')...
Putting Data ('demo/example/zenoh-rs-pub': '[   1] Pub from Rust!')...
Putting Data ('demo/example/zenoh-rs-pub': '[   2] Pub from Rust!')...
Putting Data ('demo/example/zenoh-rs-pub': '[   3] Pub from Rust!')...
Putting Data ('demo/example/zenoh-rs-pub': '[   4] Pub from Rust!')...
Putting Data ('demo/example/zenoh-rs-pub': '[   5] Pub from Rust!')...
Putting Data ('demo/example/zenoh-rs-pub': '[   6] Pub from Rust!')...
Putting Data ('demo/example/zenoh-rs-pub': '[   7] Pub from Rust!')...
Putting Data ('demo/example/zenoh-rs-pub': '[   8] Pub from Rust!')...
./target/debug/examples/z_sub
Opening session...
2024-05-15T08:20:13.840208Z  INFO main ThreadId(01) zenoh::net::runtime: Using ZID: 1e5dfa7ccfbdf79c992658a9a91a72ab
2024-05-15T08:20:13.917598Z  INFO main ThreadId(01) zenoh::net::runtime::orchestrator: Zenoh can be reached at: tcp/192.168.1.140:37831
2024-05-15T08:20:13.917792Z  INFO main ThreadId(01) zenoh::net::runtime::orchestrator: zenohd listening scout messages on 224.0.0.224:7446
Declaring Subscriber on 'demo/example/**'...
Press CTRL-C to quit...
>> [Subscriber] Received PUT ('demo/example/zenoh-rs-pub': '[   2] Pub from Rust!')
>> [Subscriber] Received PUT ('demo/example/zenoh-rs-pub': '[   3] Pub from Rust!')
>> [Subscriber] Received PUT ('demo/example/zenoh-rs-pub': '[   4] Pub from Rust!')
>> [Subscriber] Received PUT ('demo/example/zenoh-rs-pub': '[   5] Pub from Rust!')
>> [Subscriber] Received PUT ('demo/example/zenoh-rs-pub': '[   6] Pub from Rust!')
>> [Subscriber] Received PUT ('demo/example/zenoh-rs-pub': '[   7] Pub from Rust!')

@esemeniuc
Copy link
Author

I just noticed 609798f. Are you running off of 0.11.rc2?

@YuanYuYuan
Copy link
Contributor

Hi @esemeniuc, I used the latest commit. So it's newer than the 0.11.0-rc and should include the fix. Let me know if the fix doesn't work for you. 🙂

@esemeniuc
Copy link
Author

Looks like it works, thanks for looking

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants