Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zc_payload_rcinc and zc_attachment_rcinc #238

Open
milyin opened this issue Jan 25, 2024 · 1 comment · May be fixed by #251
Open

zc_payload_rcinc and zc_attachment_rcinc #238

milyin opened this issue Jan 25, 2024 · 1 comment · May be fixed by #251
Labels
enhancement New feature or request

Comments

@milyin
Copy link
Contributor

milyin commented Jan 25, 2024

Describe the feature

zc_payload_rcinc is available, but no zc_attachment_rcinc is not provided. Therefore, it is impossible for the user to move the attachment outside the callback without copying it. Moreover, when a payload is moved out of the callback and put in a queue with zc_payload_rcinc, when freeing the queue it will panic.
@milyin milyin added the enhancement New feature or request label Jan 25, 2024
@milyin milyin linked a pull request Mar 12, 2024 that will close this issue
Proposal: Sample API rework #251
Open
@milyin
Copy link
Contributor Author

milyin commented Mar 12, 2024 •
edited

This will be fixed by #251 : z_owned_sample_t will allow to get ownership of the attachment data and getting it from callback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
Zenoh 1.0.0 release
Status: In review
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Proposal: Sample API rework eclipse-zenoh/zenoh-c
1 participant
@milyin