Improve code clarity #731
Draft
Improve code clarity #731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All lwm2m_session_is_equal() does is comparing pointers. Its comment however suggests that it does more/something slightly different. Also, the 3rd, unused parameter is just cumbersome. This commit simplifies all of this by removing the code in question.
I wish this was already stated explictly when I reviewed PR eclipse-wakaama#696.
rettichschnidi
force-pushed
the
gardena/rs/ready-for-pr-696
branch
from
a4f447b
to
cb5a438
Compare
| @@ -298,7 +298,7 @@ bool transaction_handleResponse(lwm2m_context_t * contextP, | |||
|
|
|||
| while (NULL != transacP) | |||
| { | |||
| if (lwm2m_session_is_equal(fromSessionH, transacP->peerH, contextP->userData) == true) | |||
There was a problem hiding this comment.
As far as I understand it, lwm2m_session_is_equal is a function that the users of Wakaama need to implement for their platform. The implementation in the examples does indeed only compare pointers. But that might not be the right thing to do in other cases.
| // Compare two session handles | ||
| // Returns true if the two sessions identify the same peer. false otherwise. | ||
| // userData: parameter to lwm2m_init() | ||
| bool lwm2m_session_is_equal(void * session1, void * session2, void * userData); |
There was a problem hiding this comment.
See comment above about lwm2m_session_is_equal.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes implemented while trying to understand/reviewing PR #696. Details can be found in the commit messages.