Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Timeout and deadline #78

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Timeout and deadline #78

wants to merge 3 commits into from

Conversation

vietj
Copy link
Member

@vietj vietj commented Nov 14, 2023 •
edited

Supporting protocol level grpc-timeout and the io.grpc.Deadline API.

  • client and server allows to interact with grpc timeouts and schedule deadlines.
  • bridge API integrates with gRPC context and deadline and implement deadline propagation in server/client mode
  • vertx context storage has been improved to better support gRPC context handling and propagation of deadlines
  • documentation + examples
  • ...

@vietj vietj added this to the 5.0.0 milestone Nov 14, 2023
@vietj vietj force-pushed the timeout-and-deadline branch 2 times, most recently from bace434 to 62b673d Compare November 15, 2023 07:03
@vietj vietj self-assigned this Nov 15, 2023
This was linked to issues Nov 15, 2023
Deadline setting in vertx grpc stub client is ignored #76
Open
Support Timeout Propagation #37
Open
@liuchong liuchong mentioned this pull request Nov 16, 2023
Closed
liuchong
liuchong approved these changes Nov 16, 2023
View reviewed changes
Copy link

@liuchong liuchong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@vietj vietj mentioned this pull request Mar 5, 2024
Open
@yizmailovSF
Copy link

@vietj hey, is there any update on this?

@vietj
Copy link
Member Author

vietj commented May 27, 2024

@yizmailovSF resuming work on it for 5.0

@vietj vietj force-pushed the timeout-and-deadline branch 3 times, most recently from fb60ee8 to d45c6d7 Compare May 30, 2024 15:34
@vietj vietj added the enhancement New feature or request label May 30, 2024
vietj added 2 commits June 3, 2024 14:24
@vietj
Implement grpc-timeout and deadlines.
15f09e5
@vietj
Rework the timeout handling to move the gRPC context outside of the v…
c1206ec 
…ertx request/response API, update the implementation of gRPC context storage to comply agains the context requirement to attach/detach in the same method.
@vietj vietj force-pushed the timeout-and-deadline branch 2 times, most recently from 62c3094 to c3a3a6f Compare June 4, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@liuchong liuchong liuchong approved these changes

Assignees

@vietj vietj

Labels
enhancement New feature or request
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

Deadline setting in vertx grpc stub client is ignored Support Timeout Propagation
3 participants
@vietj @yizmailovSF @liuchong