Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deadline setting in vertx grpc stub client is ignored #76

Open
yizmailovSF opened this issue Nov 8, 2023 · 0 comments · May be fixed by #78
Open

Deadline setting in vertx grpc stub client is ignored #76

yizmailovSF opened this issue Nov 8, 2023 · 0 comments · May be fixed by #78
Labels
bug Something isn't working

Comments

@yizmailovSF
Copy link

Version

4.4.1

Context

When using vertx grpc client it seems that callOptions that holds deadline configuration is not being propagated to VertxClientCall.

Steps to reproduce

Create a vertx stub:

GrpcClientChannel channel =
    new GrpcClientChannel(
        GrpcClient.client(vertx),
        SocketAddress.inetSocketAddress(
            port, host));
SomeVertxStub stub = VertxSomeServiceGrpc.newVertxStub(
        channel);

Use this stub to make calls with deadline:

  stub
      .withDeadlineAfter(1, TimeUnit.MILLISECONDS)

The deadline which is a part callOptions is not being sent to VertxClientCall and not taken into account when making grpc calls so there is no way to set request timeout for grpc client calls.

@yizmailovSF yizmailovSF added the bug Something isn't working label Nov 8, 2023
@vietj vietj linked a pull request Nov 15, 2023 that will close this issue
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant